Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable tokenizer on json fields #2053

Merged
merged 3 commits into from
May 24, 2023
Merged

enable tokenizer on json fields #2053

merged 3 commits into from
May 24, 2023

Conversation

PSeitz
Copy link
Contributor

@PSeitz PSeitz commented May 19, 2023

enable tokenizer on json fields for type text
quickwit-oss/quickwit#3179

enable tokenizer on json fields for type text
@PSeitz PSeitz requested a review from fulmicoton May 22, 2023 04:52
@codecov-commenter
Copy link

Codecov Report

Merging #2053 (671b8db) into main (62709b8) will decrease coverage by 0.06%.
The diff coverage is 96.07%.

❗ Current head 671b8db differs from pull request most recent head f2b79b9. Consider uploading reports for the commit f2b79b9 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #2053      +/-   ##
==========================================
- Coverage   94.43%   94.37%   -0.06%     
==========================================
  Files         319      319              
  Lines       59689    59872     +183     
==========================================
+ Hits        56365    56504     +139     
- Misses       3324     3368      +44     
Impacted Files Coverage Δ
src/fastfield/writer.rs 94.85% <90.00%> (-0.45%) ⬇️
src/schema/text_options.rs 95.87% <94.73%> (ø)
src/fastfield/mod.rs 100.00% <100.00%> (ø)
src/fastfield/readers.rs 91.01% <100.00%> (+0.16%) ⬆️
src/schema/json_object_options.rs 92.66% <100.00%> (+1.08%) ⬆️
src/tokenizer/tokenizer.rs 100.00% <100.00%> (ø)
tokenizer-api/src/lib.rs 81.81% <100.00%> (+0.86%) ⬆️

... and 20 files with indirect coverage changes

@PSeitz PSeitz merged commit e56addc into main May 24, 2023
@PSeitz PSeitz deleted the json_fast_field_tokenizer branch May 24, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants