Change in Executor API #2391
Merged
Change in Executor API #2391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
force-pushed
the
expose-rayon
branch
2 times, most recently
from
fd1b2bc to
acd7e33
Compare
src/lib.rs
Outdated
| @@ -166,7 +166,7 @@ mod future_result; | |||
|
|
|||
| // Re-exports | |||
| pub use common::DateTime; | |||
| pub use {columnar, query_grammar, time}; | |||
| pub use {columnar, query_grammar, rayon, time}; | |||
There was a problem hiding this comment.
It did not miss anything, we actually only need to expose rayon_core because we only use ThreadPool in our public API and not ParallelIterator et al. rayon_core is supposedly much more stable exactly to make it easier to share with other crates in the dependency tree.
fulmicoton
force-pushed
the
expose-rayon
branch
4 times, most recently
from
90ab564 to
9737b5f
Compare
fulmicoton
force-pushed
the
expose-rayon
branch
2 times, most recently
from
5455dfd to
9b7b9e4
Compare
Warning, this change is mildly not backward compatible so I bumped tantivy's version.
philippemnoel
pushed a commit
to paradedb/tantivy
that referenced
this pull request
Aug 31, 2024
Warning, this change is mildly not backward compatible so I bumped tantivy's version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.