Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: packager #4304

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

WIP: packager #4304

wants to merge 5 commits into from

Conversation

sir-sigurd
Copy link
Member

Description

TODO

  • Unit tests
  • Automated tests (e.g. Preflight)
  • Confirm that this change meets security best practices and does not violate the security model
  • Documentation
    • run optipng on any new PNGs
    • Python: Run build.py for new docstrings
    • JavaScript: basic explanation and screenshot of new features
    • Markdown somewhere in docs/**/*.md that explains the feature to end users (said .md files should be linked from SUMMARY.md so they appear on https://docs.quiltdata.com)
    • Markdown docs for developers
  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.11%. Comparing base (a7e5815) to head (3c2739e).

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #4304    +/-   ##
========================================
  Coverage   39.11%   39.11%            
========================================
  Files         783      783            
  Lines       34737    34737            
  Branches     5517     5308   -209     
========================================
  Hits        13586    13586            
- Misses      19970    20608   +638     
+ Partials     1181      543   -638     
Flag Coverage Δ
api-python 91.39% <ø> (ø)
catalog 18.12% <ø> (ø)
lambda 91.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant