Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depwarns on Julia 1.7 "use values(kwargs) and keys(kwargs) instead of kwargs.data and kwargs.itr" #154

Closed
jaakkor2 opened this issue May 3, 2021 · 0 comments

Comments

@jaakkor2
Copy link
Contributor

jaakkor2 commented May 3, 2021

On Julia 1.7 JSON3 1.8.1, I see lots of warnings, and this slows down the first runs

┌ Warning: use values(kwargs) and keys(kwargs) instead of kwargs.data and kwargs.itr
│   caller = #_#67 at write.jl:118 [inlined]
└ @ Core C:\Users\jru\.julia\packages\JSON3\A0XBc\src\write.jl:118
┌ Warning: use values(kwargs) and keys(kwargs) instead of kwargs.data and kwargs.itr
│   caller = #write#68 at write.jl:131 [inlined]
└ @ Core C:\Users\jru\.julia\packages\JSON3\A0XBc\src\write.jl:131
┌ Warning: use values(kwargs) and keys(kwargs) instead of kwargs.data and kwargs.itr
│   caller = #read#30 at structs.jl:273 [inlined]
└ @ Core C:\Users\jru\.julia\packages\JSON3\A0XBc\src\structs.jl:273
┌ Warning: use values(kwargs) and keys(kwargs) instead of kwargs.data and kwargs.itr
│   caller = #_#38 at structs.jl:384 [inlined]
└ @ Core C:\Users\jru\.julia\packages\JSON3\A0XBc\src\structs.jl:384
┌ Warning: use values(kwargs) and keys(kwargs) instead of kwargs.data and kwargs.itr
│   caller = #read!#41 at structs.jl:449 [inlined]
└ @ Core C:\Users\jru\.julia\packages\JSON3\A0XBc\src\structs.jl:449
┌ Warning: use values(kwargs) and keys(kwargs) instead of kwargs.data and kwargs.itr
│   caller = #_#42 at structs.jl:493 [inlined]
└ @ Core C:\Users\jru\.julia\packages\JSON3\A0XBc\src\structs.jl:493
┌ Warning: use values(kwargs) and keys(kwargs) instead of kwargs.data and kwargs.itr
│   caller = #read#43 at structs.jl:554 [inlined]
└ @ Core C:\Users\jru\.julia\packages\JSON3\A0XBc\src\structs.jl:554

See JuliaLang/julia#39448

fredrikekre added a commit to fredrikekre/JSON3.jl that referenced this issue May 13, 2021
@quinnj quinnj closed this as completed in 1c69202 May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant