-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer #557
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A first quick pass --- don't we need Swagger updates as the model has been updated?
I wish we could find a way to make setting idleTimeout appear to be more optional than it is. I don't think it's wise to put an edge-case setting into the primary workflow of working with loadbalancers -- it may create more complication than it fixes.
docs-src/docs/reference/cli.md
Outdated
@@ -405,6 +406,7 @@ l0 loadbalancer create [--port port ... | --certificate nameOrARN | | |||
* `--healthcheck-timeout timeout` - The length of time before the check times out (default: `5`). | |||
* `--healthcheck-healthy-threshold healthyThreshold` - The number of checks before the instance is declared healthy (default: `2`). | |||
* `--healthcheck-unhealthy-threshold unhealthyThreshold` - The number of checks before the instance is declared unhealthy (default: `2`). | |||
* `--idle-timeout idleTimeout` - The ELB Idle Timeout in seconds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little confused... is --idle-timeout
a required or optional param?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, you might wanna move this out of 'required parameters' then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the truncated view of the code makes it look like it's under Required Parameters, but under the fold it should show that it is under the Optional Arguments section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahhh opps, apologies then!
docs-src/docs/reference/cli.md
Outdated
@@ -512,6 +514,18 @@ l0 loadbalancer healthcheck [--set-target target | --set-interval interval | | |||
#### Additional information | |||
Calling the subcommand without flags will display the current configuration of the load balancer's health check. Setting any of the flags will update the corresponding field in the health check, and all omitted flags will leave the corresponding fields unchanged. | |||
|
|||
### loadbalancer idletimeout | |||
Use the `idletimeout` subcommand to update the ELB Idle Timout of a load balancer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume it can be used to view the current idle timeout as well? Also [nit] Timout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
l0 loadbalancer get
has now been modified to show the idle timeout of the load balancer. The subcommand idletimeout
is just to update the loadbalancer's idle timeout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although it should be noted that if the load balancer's idle timeout is updated, then the printer will print the load balancer with the new idle timeout value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, i think that's different behavior from the healthcheck
subcommand, for example. I'm not sure if i agree that idletimeout
deserves to be part of loadbalancer get
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what I'm going to do is make it behave like healthcheck
but I'd prefer leaving the loadbalancer get
column that I added in.
cli.IntFlag{ | ||
Name: "idle-timeout", | ||
Value: 60, | ||
Usage: "idle timeout of the load balancer in seconds", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should give users some more help on what this value is and how rare it would be to set it to anything other than default?
I've personally never set this value to anything other than default...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should that explanation be here or in the documentation? It seems like I should put a more verbose description in the documentation rather than here in the CLI context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've opted to add a couple of sections to the CLI and Terraform Plugin reference pages with a more thorough explanation of what the idle timeout is.
docs-src/docs/reference/cli.md
Outdated
@@ -405,6 +406,7 @@ l0 loadbalancer create [--port port ... | --certificate nameOrARN | | |||
* `--healthcheck-timeout timeout` - The length of time before the check times out (default: `5`). | |||
* `--healthcheck-healthy-threshold healthyThreshold` - The number of checks before the instance is declared healthy (default: `2`). | |||
* `--healthcheck-unhealthy-threshold unhealthyThreshold` - The number of checks before the instance is declared unhealthy (default: `2`). | |||
* `--idle-timeout idleTimeout` - The ELB Idle Timeout in seconds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We generally avoid referring to 'ELB' in our docs
docs-src/docs/reference/cli.md
Outdated
@@ -512,6 +514,18 @@ l0 loadbalancer healthcheck [--set-target target | --set-interval interval | | |||
#### Additional information | |||
Calling the subcommand without flags will display the current configuration of the load balancer's health check. Setting any of the flags will update the corresponding field in the health check, and all omitted flags will leave the corresponding fields unchanged. | |||
|
|||
### loadbalancer idletimeout | |||
Use the `idletimeout` subcommand to update the ELB Idle Timout of a load balancer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto re: avoiding reference to ELB
docs-src/docs/reference/cli.md
Outdated
|
||
#### Required parameters | ||
* `loadBalancerName` - The name of the existing Layer0 load balancer you are modifying. | ||
* `idleTimeout` - The ELB Idle Timeout in seconds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto re: avoiding reference to ELB
@@ -365,6 +367,7 @@ The following arguments are supported: | |||
* `private` - (Optional) If true, the load balancer will not be exposed to the public internet | |||
* `port` - (Optional, Default: 80:80/tcp) A list of port blocks. Ports documented below | |||
* `health_check` - (Optional, Default: `{"TCP:80" 30 5 2 2}`) A health_check block. Health check documented below | |||
* `idle_timeout` - (Optiona, Default: 60) The ELB Idle Timeout of the load balancer in seconds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto re: avoiding reference to ELB
Re: the comment about Swagger updates, it was updated to the extent that I could here: https://github.com/quintilesims/layer0/pull/557/files/10b08bfdc37b962ea6383fbc772573a9b0fff523#diff-3d7954424b8a45d741cc730ba1391e5eR140 Edit: Sorry, wrong link to the pertinent swagger update. It is here (which is picked up by swagger): https://github.com/quintilesims/layer0/blob/553-jparsons-elb-timeout/api/handlers/load_balancer_handler.go#L79 |
@@ -1,6 +1,8 @@ | |||
// Generated by go-decorator, DO NOT EDIT | |||
package elb | |||
|
|||
import () |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I can remove this.
@@ -71,7 +71,14 @@ func (e *ECSLoadBalancerManager) GetLoadBalancer(loadBalancerID string) (*models | |||
return nil, err | |||
} | |||
|
|||
return e.populateModel(loadBalancer), nil | |||
lbAttributes, err := e.ELB.DescribeLoadBalancerAttributes((*loadBalancer.LoadBalancerName)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to safely de-ref using aws.StringValue(loadBalancer.LoadBalancerName)
lbAttributes, err := e.ELB.DescribeLoadBalancerAttributes((*loadBalancer.LoadBalancerName)) | ||
if err != nil { | ||
if ContainsErrCode(err, "LoadBalancerAttributeNotFound") { | ||
return nil, errors.New(errors.LoadBalancerAttributeNotFound, err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should only catch/handle errors if we can do something meaningful with it; this looks like we are just passing the error though here.
@@ -206,6 +213,7 @@ func (e *ECSLoadBalancerManager) populateModel(description *elb.LoadBalancerDesc | |||
IsPublic: stringOrEmpty(description.Scheme) == "internet-facing", | |||
URL: stringOrEmpty(description.DNSName), | |||
HealthCheck: healthCheck, | |||
IdleTimeout: int(*lbAttributes.ConnectionSettings.IdleTimeout), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs safe-dereference
@@ -349,6 +364,15 @@ func (e *ECSLoadBalancerManager) UpdateLoadBalancerHealthCheck(loadBalancerID st | |||
return e.GetLoadBalancer(loadBalancerID) | |||
} | |||
|
|||
func (e *ECSLoadBalancerManager) UpdateLoadBalancerIdleTimeout(loadBalancerID string, idleTimeout int) (*models.LoadBalancer, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update should only return errors; adding return e.GetLoadBalancer(loadBalancerID)
is coupling this function to GetLoadBalancer
, which will make this much harder to test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does UpdateLoadBalancerHealthCheck
use this pattern in that case? I modeled this behavior off of the healthcheck
subcommand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah I see - was thinking about api-refactor
patterns instead of the ones in develop
- disregard!
@@ -221,11 +233,14 @@ func TestCreateLoadBalancer(t *testing.T) { | |||
mockLB.ELB.EXPECT(). | |||
ConfigureHealthCheck(loadBalancerID.String(), elbHealthCheck) | |||
|
|||
mockLB.ELB.EXPECT(). | |||
SetIdleTimeout(loadBalancerID.String(), 60) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should specify what you are returning here
Return(loadBalancerAttributes, nil) | ||
|
||
mockLB.ELB.EXPECT(). | ||
SetIdleTimeout(loadBalancerID.String(), 60) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
cli/command/load_balancer_command.go
Outdated
return err | ||
} | ||
|
||
if timeout := args["TIMEOUT"]; timeout != "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will never happen because extractArgs
would error if it was not specified
@@ -20,6 +20,7 @@ func (t *TestPrinter) PrintJobs(...*models.Job) error | |||
func (t *TestPrinter) PrintLoadBalancers(...*models.LoadBalancer) error { return nil } | |||
func (t *TestPrinter) PrintLoadBalancerSummaries(...*models.LoadBalancerSummary) error { return nil } | |||
func (t *TestPrinter) PrintLoadBalancerHealthCheck(*models.LoadBalancer) error { return nil } | |||
func (t *TestPrinter) PrintLoadBalancerIdleTimeout(*models.LoadBalancer) error { return nil } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where would this be used? i don't think we need this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is used in the l0 loadbalancer idletimeout
subcommand. See here: https://github.com/quintilesims/layer0/blob/553-jparsons-elb-timeout/cli/command/load_balancer_command.go#L419
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like this UX is based off of the healthcheck pattern, which isn't very good IMO. I think it would be better to base this off of something like l0 service scale
@@ -237,6 +238,28 @@ func (t *TextPrinter) PrintLoadBalancerHealthCheck(loadBalancer *models.LoadBala | |||
return nil | |||
} | |||
|
|||
func (t *TextPrinter) PrintLoadBalancerIdleTimeout(loadBalancer *models.LoadBalancer) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto - i don't see this being used anywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above comment.
…error handle in lb attrib describe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My comment regarding the UX of l0 loadbalancer idletimeout
doesn't need to be a blocker, it can be mereged as-is. However, I think it should be cleaned up before we merge it into api-refactor
* 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) Adds CLI functionality for l0 loadbalancer create and a new subcommand l0 loadbalancer idletimeout. Create has a new optional flag --idle-timeout for create which can be used to specify the Idle Timeout of the load balancer at creation time. l0 loadbalancer idletimeout is an update subcommand that updates a given load balancer's idle timeout to a new value. Adds Terraform support for defining a load balancer's Idle Timeout. A new key is introduced into the resource, idle_timeout. * MAINT: Build docs for v0.10.7 release
* Merge for CI testing. (#527) * v0.10.4 docfixes tlake (#492) * Fixes in guides/ and reference/ * Update admonition * Remove deprecated 'apply-smoketest' target * Remove smoketests from CI pipeline * Code review updates * Clean up deprecated smoketest targets * Update docs * Update release notes and add script to update version (#495) * Update release notes and add script to update version * Add make script for updating release * Update release notes * Update travis with github release * Update travis * Test travis * Update travis * Fix travis * Update travis to build binaries for github * Update travis build and rework release flow * Move to expenv and removed release notes, reduntant * Update release notes with new flow * PR Feedback changes, fix makefile * Fix .zip missing in index * Remove l0_version * Remove dependency for prefix v * PR Feedback changes' * Fix regex * Update to v0.10.5 for docs and back expenv * Fix travis script * Update travis script * Update travis script * Update travis script * Fix travis script order * Fix docker env in travis * Fix docker login * Add expenv to before_deploy * Updated docs for v0.10.6 * Release v0.10.7 (#560) * 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) Adds CLI functionality for l0 loadbalancer create and a new subcommand l0 loadbalancer idletimeout. Create has a new optional flag --idle-timeout for create which can be used to specify the Idle Timeout of the load balancer at creation time. l0 loadbalancer idletimeout is an update subcommand that updates a given load balancer's idle timeout to a new value. Adds Terraform support for defining a load balancer's Idle Timeout. A new key is introduced into the resource, idle_timeout. * MAINT: Build docs for v0.10.7 release
* 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) * 553: Allow Load Balancer Idle Timeout to be defined at creation time * 553: Fix breaking unit tests on idle timeout type casting * 553: Add update idle timeout cli functionality * 553: More work on fixing unit tests * 553: Fix command unit test, add printer unit test * 553: Fix remaining unit tests, add documentation * 553: Remove ELB references in docs and some review changes * 553: Make idletimeout subcommand print if no update is required * 553: Add additional documentation explaining what the Idle Timeout it * 553: Remove unnecessary import statement in elb provider decorator * 553: Make review fixes, dereferencing IdleTimeout, add more explicit error handle in lb attrib describe * 553: Modify load balancer command to ParseInt timeout rather than Atoi conversion * 533: Change spacing in cli reference docs page * Sync develop and master - v0.10.7 release (#561) * Merge for CI testing. (#527) * v0.10.4 docfixes tlake (#492) * Fixes in guides/ and reference/ * Update admonition * Remove deprecated 'apply-smoketest' target * Remove smoketests from CI pipeline * Code review updates * Clean up deprecated smoketest targets * Update docs * Update release notes and add script to update version (#495) * Update release notes and add script to update version * Add make script for updating release * Update release notes * Update travis with github release * Update travis * Test travis * Update travis * Fix travis * Update travis to build binaries for github * Update travis build and rework release flow * Move to expenv and removed release notes, reduntant * Update release notes with new flow * PR Feedback changes, fix makefile * Fix .zip missing in index * Remove l0_version * Remove dependency for prefix v * PR Feedback changes' * Fix regex * Update to v0.10.5 for docs and back expenv * Fix travis script * Update travis script * Update travis script * Update travis script * Fix travis script order * Fix docker env in travis * Fix docker login * Add expenv to before_deploy * Updated docs for v0.10.6 * Release v0.10.7 (#560) * 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) Adds CLI functionality for l0 loadbalancer create and a new subcommand l0 loadbalancer idletimeout. Create has a new optional flag --idle-timeout for create which can be used to specify the Idle Timeout of the load balancer at creation time. l0 loadbalancer idletimeout is an update subcommand that updates a given load balancer's idle timeout to a new value. Adds Terraform support for defining a load balancer's Idle Timeout. A new key is introduced into the resource, idle_timeout. * MAINT: Build docs for v0.10.7 release * MAINT: Doc fixes post v0.10.7 release
* 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) * 553: Allow Load Balancer Idle Timeout to be defined at creation time * 553: Fix breaking unit tests on idle timeout type casting * 553: Add update idle timeout cli functionality * 553: More work on fixing unit tests * 553: Fix command unit test, add printer unit test * 553: Fix remaining unit tests, add documentation * 553: Remove ELB references in docs and some review changes * 553: Make idletimeout subcommand print if no update is required * 553: Add additional documentation explaining what the Idle Timeout it * 553: Remove unnecessary import statement in elb provider decorator * 553: Make review fixes, dereferencing IdleTimeout, add more explicit error handle in lb attrib describe * 553: Modify load balancer command to ParseInt timeout rather than Atoi conversion * 533: Change spacing in cli reference docs page * Sync develop and master - v0.10.7 release (#561) * Merge for CI testing. (#527) * v0.10.4 docfixes tlake (#492) * Fixes in guides/ and reference/ * Update admonition * Remove deprecated 'apply-smoketest' target * Remove smoketests from CI pipeline * Code review updates * Clean up deprecated smoketest targets * Update docs * Update release notes and add script to update version (#495) * Update release notes and add script to update version * Add make script for updating release * Update release notes * Update travis with github release * Update travis * Test travis * Update travis * Fix travis * Update travis to build binaries for github * Update travis build and rework release flow * Move to expenv and removed release notes, reduntant * Update release notes with new flow * PR Feedback changes, fix makefile * Fix .zip missing in index * Remove l0_version * Remove dependency for prefix v * PR Feedback changes' * Fix regex * Update to v0.10.5 for docs and back expenv * Fix travis script * Update travis script * Update travis script * Update travis script * Fix travis script order * Fix docker env in travis * Fix docker login * Add expenv to before_deploy * Updated docs for v0.10.6 * Release v0.10.7 (#560) * 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) Adds CLI functionality for l0 loadbalancer create and a new subcommand l0 loadbalancer idletimeout. Create has a new optional flag --idle-timeout for create which can be used to specify the Idle Timeout of the load balancer at creation time. l0 loadbalancer idletimeout is an update subcommand that updates a given load balancer's idle timeout to a new value. Adds Terraform support for defining a load balancer's Idle Timeout. A new key is introduced into the resource, idle_timeout. * MAINT: Build docs for v0.10.7 release * MAINT: Doc fixes post v0.10.7 release * MAINT: Docs site rebuilt post v0.10.7 release
* 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) * 553: Allow Load Balancer Idle Timeout to be defined at creation time * 553: Fix breaking unit tests on idle timeout type casting * 553: Add update idle timeout cli functionality * 553: More work on fixing unit tests * 553: Fix command unit test, add printer unit test * 553: Fix remaining unit tests, add documentation * 553: Remove ELB references in docs and some review changes * 553: Make idletimeout subcommand print if no update is required * 553: Add additional documentation explaining what the Idle Timeout it * 553: Remove unnecessary import statement in elb provider decorator * 553: Make review fixes, dereferencing IdleTimeout, add more explicit error handle in lb attrib describe * 553: Modify load balancer command to ParseInt timeout rather than Atoi conversion * 533: Change spacing in cli reference docs page * Sync develop and master - v0.10.7 release (#561) * Merge for CI testing. (#527) * v0.10.4 docfixes tlake (#492) * Fixes in guides/ and reference/ * Update admonition * Remove deprecated 'apply-smoketest' target * Remove smoketests from CI pipeline * Code review updates * Clean up deprecated smoketest targets * Update docs * Update release notes and add script to update version (#495) * Update release notes and add script to update version * Add make script for updating release * Update release notes * Update travis with github release * Update travis * Test travis * Update travis * Fix travis * Update travis to build binaries for github * Update travis build and rework release flow * Move to expenv and removed release notes, reduntant * Update release notes with new flow * PR Feedback changes, fix makefile * Fix .zip missing in index * Remove l0_version * Remove dependency for prefix v * PR Feedback changes' * Fix regex * Update to v0.10.5 for docs and back expenv * Fix travis script * Update travis script * Update travis script * Update travis script * Fix travis script order * Fix docker env in travis * Fix docker login * Add expenv to before_deploy * Updated docs for v0.10.6 * Release v0.10.7 (#560) * 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) Adds CLI functionality for l0 loadbalancer create and a new subcommand l0 loadbalancer idletimeout. Create has a new optional flag --idle-timeout for create which can be used to specify the Idle Timeout of the load balancer at creation time. l0 loadbalancer idletimeout is an update subcommand that updates a given load balancer's idle timeout to a new value. Adds Terraform support for defining a load balancer's Idle Timeout. A new key is introduced into the resource, idle_timeout. * MAINT: Build docs for v0.10.7 release * MAINT: Doc fixes post v0.10.7 release * MAINT: Docs site rebuilt post v0.10.7 release * Document breaking change within v0.10.x family * Add merge type for release branch into master
* Rebuild docs site post v0.10.7 release (#563) * 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) * 553: Allow Load Balancer Idle Timeout to be defined at creation time * 553: Fix breaking unit tests on idle timeout type casting * 553: Add update idle timeout cli functionality * 553: More work on fixing unit tests * 553: Fix command unit test, add printer unit test * 553: Fix remaining unit tests, add documentation * 553: Remove ELB references in docs and some review changes * 553: Make idletimeout subcommand print if no update is required * 553: Add additional documentation explaining what the Idle Timeout it * 553: Remove unnecessary import statement in elb provider decorator * 553: Make review fixes, dereferencing IdleTimeout, add more explicit error handle in lb attrib describe * 553: Modify load balancer command to ParseInt timeout rather than Atoi conversion * 533: Change spacing in cli reference docs page * Sync develop and master - v0.10.7 release (#561) * Merge for CI testing. (#527) * v0.10.4 docfixes tlake (#492) * Fixes in guides/ and reference/ * Update admonition * Remove deprecated 'apply-smoketest' target * Remove smoketests from CI pipeline * Code review updates * Clean up deprecated smoketest targets * Update docs * Update release notes and add script to update version (#495) * Update release notes and add script to update version * Add make script for updating release * Update release notes * Update travis with github release * Update travis * Test travis * Update travis * Fix travis * Update travis to build binaries for github * Update travis build and rework release flow * Move to expenv and removed release notes, reduntant * Update release notes with new flow * PR Feedback changes, fix makefile * Fix .zip missing in index * Remove l0_version * Remove dependency for prefix v * PR Feedback changes' * Fix regex * Update to v0.10.5 for docs and back expenv * Fix travis script * Update travis script * Update travis script * Update travis script * Fix travis script order * Fix docker env in travis * Fix docker login * Add expenv to before_deploy * Updated docs for v0.10.6 * Release v0.10.7 (#560) * 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) Adds CLI functionality for l0 loadbalancer create and a new subcommand l0 loadbalancer idletimeout. Create has a new optional flag --idle-timeout for create which can be used to specify the Idle Timeout of the load balancer at creation time. l0 loadbalancer idletimeout is an update subcommand that updates a given load balancer's idle timeout to a new value. Adds Terraform support for defining a load balancer's Idle Timeout. A new key is introduced into the resource, idle_timeout. * MAINT: Build docs for v0.10.7 release * MAINT: Doc fixes post v0.10.7 release * MAINT: Docs site rebuilt post v0.10.7 release * Document breaking change within v0.10.x family (#574) * 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) * 553: Allow Load Balancer Idle Timeout to be defined at creation time * 553: Fix breaking unit tests on idle timeout type casting * 553: Add update idle timeout cli functionality * 553: More work on fixing unit tests * 553: Fix command unit test, add printer unit test * 553: Fix remaining unit tests, add documentation * 553: Remove ELB references in docs and some review changes * 553: Make idletimeout subcommand print if no update is required * 553: Add additional documentation explaining what the Idle Timeout it * 553: Remove unnecessary import statement in elb provider decorator * 553: Make review fixes, dereferencing IdleTimeout, add more explicit error handle in lb attrib describe * 553: Modify load balancer command to ParseInt timeout rather than Atoi conversion * 533: Change spacing in cli reference docs page * Sync develop and master - v0.10.7 release (#561) * Merge for CI testing. (#527) * v0.10.4 docfixes tlake (#492) * Fixes in guides/ and reference/ * Update admonition * Remove deprecated 'apply-smoketest' target * Remove smoketests from CI pipeline * Code review updates * Clean up deprecated smoketest targets * Update docs * Update release notes and add script to update version (#495) * Update release notes and add script to update version * Add make script for updating release * Update release notes * Update travis with github release * Update travis * Test travis * Update travis * Fix travis * Update travis to build binaries for github * Update travis build and rework release flow * Move to expenv and removed release notes, reduntant * Update release notes with new flow * PR Feedback changes, fix makefile * Fix .zip missing in index * Remove l0_version * Remove dependency for prefix v * PR Feedback changes' * Fix regex * Update to v0.10.5 for docs and back expenv * Fix travis script * Update travis script * Update travis script * Update travis script * Fix travis script order * Fix docker env in travis * Fix docker login * Add expenv to before_deploy * Updated docs for v0.10.6 * Release v0.10.7 (#560) * 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) Adds CLI functionality for l0 loadbalancer create and a new subcommand l0 loadbalancer idletimeout. Create has a new optional flag --idle-timeout for create which can be used to specify the Idle Timeout of the load balancer at creation time. l0 loadbalancer idletimeout is an update subcommand that updates a given load balancer's idle timeout to a new value. Adds Terraform support for defining a load balancer's Idle Timeout. A new key is introduced into the resource, idle_timeout. * MAINT: Build docs for v0.10.7 release * MAINT: Doc fixes post v0.10.7 release * MAINT: Docs site rebuilt post v0.10.7 release * Document breaking change within v0.10.x family * Add merge type for release branch into master
* Rebuild docs site post v0.10.7 release (#563) * 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) * 553: Allow Load Balancer Idle Timeout to be defined at creation time * 553: Fix breaking unit tests on idle timeout type casting * 553: Add update idle timeout cli functionality * 553: More work on fixing unit tests * 553: Fix command unit test, add printer unit test * 553: Fix remaining unit tests, add documentation * 553: Remove ELB references in docs and some review changes * 553: Make idletimeout subcommand print if no update is required * 553: Add additional documentation explaining what the Idle Timeout it * 553: Remove unnecessary import statement in elb provider decorator * 553: Make review fixes, dereferencing IdleTimeout, add more explicit error handle in lb attrib describe * 553: Modify load balancer command to ParseInt timeout rather than Atoi conversion * 533: Change spacing in cli reference docs page * Sync develop and master - v0.10.7 release (#561) * Merge for CI testing. (#527) * v0.10.4 docfixes tlake (#492) * Fixes in guides/ and reference/ * Update admonition * Remove deprecated 'apply-smoketest' target * Remove smoketests from CI pipeline * Code review updates * Clean up deprecated smoketest targets * Update docs * Update release notes and add script to update version (#495) * Update release notes and add script to update version * Add make script for updating release * Update release notes * Update travis with github release * Update travis * Test travis * Update travis * Fix travis * Update travis to build binaries for github * Update travis build and rework release flow * Move to expenv and removed release notes, reduntant * Update release notes with new flow * PR Feedback changes, fix makefile * Fix .zip missing in index * Remove l0_version * Remove dependency for prefix v * PR Feedback changes' * Fix regex * Update to v0.10.5 for docs and back expenv * Fix travis script * Update travis script * Update travis script * Update travis script * Fix travis script order * Fix docker env in travis * Fix docker login * Add expenv to before_deploy * Updated docs for v0.10.6 * Release v0.10.7 (#560) * 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) Adds CLI functionality for l0 loadbalancer create and a new subcommand l0 loadbalancer idletimeout. Create has a new optional flag --idle-timeout for create which can be used to specify the Idle Timeout of the load balancer at creation time. l0 loadbalancer idletimeout is an update subcommand that updates a given load balancer's idle timeout to a new value. Adds Terraform support for defining a load balancer's Idle Timeout. A new key is introduced into the resource, idle_timeout. * MAINT: Build docs for v0.10.7 release * MAINT: Doc fixes post v0.10.7 release * MAINT: Docs site rebuilt post v0.10.7 release * Document breaking change within v0.10.x family (#574) * 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) * 553: Allow Load Balancer Idle Timeout to be defined at creation time * 553: Fix breaking unit tests on idle timeout type casting * 553: Add update idle timeout cli functionality * 553: More work on fixing unit tests * 553: Fix command unit test, add printer unit test * 553: Fix remaining unit tests, add documentation * 553: Remove ELB references in docs and some review changes * 553: Make idletimeout subcommand print if no update is required * 553: Add additional documentation explaining what the Idle Timeout it * 553: Remove unnecessary import statement in elb provider decorator * 553: Make review fixes, dereferencing IdleTimeout, add more explicit error handle in lb attrib describe * 553: Modify load balancer command to ParseInt timeout rather than Atoi conversion * 533: Change spacing in cli reference docs page * Sync develop and master - v0.10.7 release (#561) * Merge for CI testing. (#527) * v0.10.4 docfixes tlake (#492) * Fixes in guides/ and reference/ * Update admonition * Remove deprecated 'apply-smoketest' target * Remove smoketests from CI pipeline * Code review updates * Clean up deprecated smoketest targets * Update docs * Update release notes and add script to update version (#495) * Update release notes and add script to update version * Add make script for updating release * Update release notes * Update travis with github release * Update travis * Test travis * Update travis * Fix travis * Update travis to build binaries for github * Update travis build and rework release flow * Move to expenv and removed release notes, reduntant * Update release notes with new flow * PR Feedback changes, fix makefile * Fix .zip missing in index * Remove l0_version * Remove dependency for prefix v * PR Feedback changes' * Fix regex * Update to v0.10.5 for docs and back expenv * Fix travis script * Update travis script * Update travis script * Update travis script * Fix travis script order * Fix docker env in travis * Fix docker login * Add expenv to before_deploy * Updated docs for v0.10.6 * Release v0.10.7 (#560) * 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) Adds CLI functionality for l0 loadbalancer create and a new subcommand l0 loadbalancer idletimeout. Create has a new optional flag --idle-timeout for create which can be used to specify the Idle Timeout of the load balancer at creation time. l0 loadbalancer idletimeout is an update subcommand that updates a given load balancer's idle timeout to a new value. Adds Terraform support for defining a load balancer's Idle Timeout. A new key is introduced into the resource, idle_timeout. * MAINT: Build docs for v0.10.7 release * MAINT: Doc fixes post v0.10.7 release * MAINT: Docs site rebuilt post v0.10.7 release * Document breaking change within v0.10.x family * Add merge type for release branch into master * 596: Update AWS SDK vendoring (#597) * 596: Update AWS SDK vendoring The vendored version of the AWS SDK is being updated to account for recent changes that have been made in the SDK. As it pertains to the issue that is being addressed, ECS ContainerDefinitions have added new properties that we should support when l0 deploys are created. * MAINT: Update broken README links * MAINT: Update v0.10.8 docs
* Rebuild docs site post v0.10.7 release (#563) * 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) * 553: Allow Load Balancer Idle Timeout to be defined at creation time * 553: Fix breaking unit tests on idle timeout type casting * 553: Add update idle timeout cli functionality * 553: More work on fixing unit tests * 553: Fix command unit test, add printer unit test * 553: Fix remaining unit tests, add documentation * 553: Remove ELB references in docs and some review changes * 553: Make idletimeout subcommand print if no update is required * 553: Add additional documentation explaining what the Idle Timeout it * 553: Remove unnecessary import statement in elb provider decorator * 553: Make review fixes, dereferencing IdleTimeout, add more explicit error handle in lb attrib describe * 553: Modify load balancer command to ParseInt timeout rather than Atoi conversion * 533: Change spacing in cli reference docs page * Sync develop and master - v0.10.7 release (#561) * Merge for CI testing. (#527) * v0.10.4 docfixes tlake (#492) * Fixes in guides/ and reference/ * Update admonition * Remove deprecated 'apply-smoketest' target * Remove smoketests from CI pipeline * Code review updates * Clean up deprecated smoketest targets * Update docs * Update release notes and add script to update version (#495) * Update release notes and add script to update version * Add make script for updating release * Update release notes * Update travis with github release * Update travis * Test travis * Update travis * Fix travis * Update travis to build binaries for github * Update travis build and rework release flow * Move to expenv and removed release notes, reduntant * Update release notes with new flow * PR Feedback changes, fix makefile * Fix .zip missing in index * Remove l0_version * Remove dependency for prefix v * PR Feedback changes' * Fix regex * Update to v0.10.5 for docs and back expenv * Fix travis script * Update travis script * Update travis script * Update travis script * Fix travis script order * Fix docker env in travis * Fix docker login * Add expenv to before_deploy * Updated docs for v0.10.6 * Release v0.10.7 (#560) * 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) Adds CLI functionality for l0 loadbalancer create and a new subcommand l0 loadbalancer idletimeout. Create has a new optional flag --idle-timeout for create which can be used to specify the Idle Timeout of the load balancer at creation time. l0 loadbalancer idletimeout is an update subcommand that updates a given load balancer's idle timeout to a new value. Adds Terraform support for defining a load balancer's Idle Timeout. A new key is introduced into the resource, idle_timeout. * MAINT: Build docs for v0.10.7 release * MAINT: Doc fixes post v0.10.7 release * MAINT: Docs site rebuilt post v0.10.7 release * Document breaking change within v0.10.x family (#574) * 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) * 553: Allow Load Balancer Idle Timeout to be defined at creation time * 553: Fix breaking unit tests on idle timeout type casting * 553: Add update idle timeout cli functionality * 553: More work on fixing unit tests * 553: Fix command unit test, add printer unit test * 553: Fix remaining unit tests, add documentation * 553: Remove ELB references in docs and some review changes * 553: Make idletimeout subcommand print if no update is required * 553: Add additional documentation explaining what the Idle Timeout it * 553: Remove unnecessary import statement in elb provider decorator * 553: Make review fixes, dereferencing IdleTimeout, add more explicit error handle in lb attrib describe * 553: Modify load balancer command to ParseInt timeout rather than Atoi conversion * 533: Change spacing in cli reference docs page * Sync develop and master - v0.10.7 release (#561) * Merge for CI testing. (#527) * v0.10.4 docfixes tlake (#492) * Fixes in guides/ and reference/ * Update admonition * Remove deprecated 'apply-smoketest' target * Remove smoketests from CI pipeline * Code review updates * Clean up deprecated smoketest targets * Update docs * Update release notes and add script to update version (#495) * Update release notes and add script to update version * Add make script for updating release * Update release notes * Update travis with github release * Update travis * Test travis * Update travis * Fix travis * Update travis to build binaries for github * Update travis build and rework release flow * Move to expenv and removed release notes, reduntant * Update release notes with new flow * PR Feedback changes, fix makefile * Fix .zip missing in index * Remove l0_version * Remove dependency for prefix v * PR Feedback changes' * Fix regex * Update to v0.10.5 for docs and back expenv * Fix travis script * Update travis script * Update travis script * Update travis script * Fix travis script order * Fix docker env in travis * Fix docker login * Add expenv to before_deploy * Updated docs for v0.10.6 * Release v0.10.7 (#560) * 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) Adds CLI functionality for l0 loadbalancer create and a new subcommand l0 loadbalancer idletimeout. Create has a new optional flag --idle-timeout for create which can be used to specify the Idle Timeout of the load balancer at creation time. l0 loadbalancer idletimeout is an update subcommand that updates a given load balancer's idle timeout to a new value. Adds Terraform support for defining a load balancer's Idle Timeout. A new key is introduced into the resource, idle_timeout. * MAINT: Build docs for v0.10.7 release * MAINT: Doc fixes post v0.10.7 release * MAINT: Docs site rebuilt post v0.10.7 release * Document breaking change within v0.10.x family * Add merge type for release branch into master * 596: Update AWS SDK vendoring (#597) * 596: Update AWS SDK vendoring The vendored version of the AWS SDK is being updated to account for recent changes that have been made in the SDK. As it pertains to the issue that is being addressed, ECS ContainerDefinitions have added new properties that we should support when l0 deploys are created. * MAINT: Update broken README links * MAINT: Update v0.10.8 docs * Release v0.10.9 (#623) * Fixes a bug that has existed since v0.10.4 wherein copies of the rate limiter would be created but never destroyed, thus creating a CPU leak that would eventually cripple the Layer0 API instance.
* Rebuild docs site post v0.10.7 release (#563) * 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) * 553: Allow Load Balancer Idle Timeout to be defined at creation time * 553: Fix breaking unit tests on idle timeout type casting * 553: Add update idle timeout cli functionality * 553: More work on fixing unit tests * 553: Fix command unit test, add printer unit test * 553: Fix remaining unit tests, add documentation * 553: Remove ELB references in docs and some review changes * 553: Make idletimeout subcommand print if no update is required * 553: Add additional documentation explaining what the Idle Timeout it * 553: Remove unnecessary import statement in elb provider decorator * 553: Make review fixes, dereferencing IdleTimeout, add more explicit error handle in lb attrib describe * 553: Modify load balancer command to ParseInt timeout rather than Atoi conversion * 533: Change spacing in cli reference docs page * Sync develop and master - v0.10.7 release (#561) * Merge for CI testing. (#527) * v0.10.4 docfixes tlake (#492) * Fixes in guides/ and reference/ * Update admonition * Remove deprecated 'apply-smoketest' target * Remove smoketests from CI pipeline * Code review updates * Clean up deprecated smoketest targets * Update docs * Update release notes and add script to update version (#495) * Update release notes and add script to update version * Add make script for updating release * Update release notes * Update travis with github release * Update travis * Test travis * Update travis * Fix travis * Update travis to build binaries for github * Update travis build and rework release flow * Move to expenv and removed release notes, reduntant * Update release notes with new flow * PR Feedback changes, fix makefile * Fix .zip missing in index * Remove l0_version * Remove dependency for prefix v * PR Feedback changes' * Fix regex * Update to v0.10.5 for docs and back expenv * Fix travis script * Update travis script * Update travis script * Update travis script * Fix travis script order * Fix docker env in travis * Fix docker login * Add expenv to before_deploy * Updated docs for v0.10.6 * Release v0.10.7 (#560) * 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) Adds CLI functionality for l0 loadbalancer create and a new subcommand l0 loadbalancer idletimeout. Create has a new optional flag --idle-timeout for create which can be used to specify the Idle Timeout of the load balancer at creation time. l0 loadbalancer idletimeout is an update subcommand that updates a given load balancer's idle timeout to a new value. Adds Terraform support for defining a load balancer's Idle Timeout. A new key is introduced into the resource, idle_timeout. * MAINT: Build docs for v0.10.7 release * MAINT: Doc fixes post v0.10.7 release * MAINT: Docs site rebuilt post v0.10.7 release * Document breaking change within v0.10.x family (#574) * 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) * 553: Allow Load Balancer Idle Timeout to be defined at creation time * 553: Fix breaking unit tests on idle timeout type casting * 553: Add update idle timeout cli functionality * 553: More work on fixing unit tests * 553: Fix command unit test, add printer unit test * 553: Fix remaining unit tests, add documentation * 553: Remove ELB references in docs and some review changes * 553: Make idletimeout subcommand print if no update is required * 553: Add additional documentation explaining what the Idle Timeout it * 553: Remove unnecessary import statement in elb provider decorator * 553: Make review fixes, dereferencing IdleTimeout, add more explicit error handle in lb attrib describe * 553: Modify load balancer command to ParseInt timeout rather than Atoi conversion * 533: Change spacing in cli reference docs page * Sync develop and master - v0.10.7 release (#561) * Merge for CI testing. (#527) * v0.10.4 docfixes tlake (#492) * Fixes in guides/ and reference/ * Update admonition * Remove deprecated 'apply-smoketest' target * Remove smoketests from CI pipeline * Code review updates * Clean up deprecated smoketest targets * Update docs * Update release notes and add script to update version (#495) * Update release notes and add script to update version * Add make script for updating release * Update release notes * Update travis with github release * Update travis * Test travis * Update travis * Fix travis * Update travis to build binaries for github * Update travis build and rework release flow * Move to expenv and removed release notes, reduntant * Update release notes with new flow * PR Feedback changes, fix makefile * Fix .zip missing in index * Remove l0_version * Remove dependency for prefix v * PR Feedback changes' * Fix regex * Update to v0.10.5 for docs and back expenv * Fix travis script * Update travis script * Update travis script * Update travis script * Fix travis script order * Fix docker env in travis * Fix docker login * Add expenv to before_deploy * Updated docs for v0.10.6 * Release v0.10.7 (#560) * 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) Adds CLI functionality for l0 loadbalancer create and a new subcommand l0 loadbalancer idletimeout. Create has a new optional flag --idle-timeout for create which can be used to specify the Idle Timeout of the load balancer at creation time. l0 loadbalancer idletimeout is an update subcommand that updates a given load balancer's idle timeout to a new value. Adds Terraform support for defining a load balancer's Idle Timeout. A new key is introduced into the resource, idle_timeout. * MAINT: Build docs for v0.10.7 release * MAINT: Doc fixes post v0.10.7 release * MAINT: Docs site rebuilt post v0.10.7 release * Document breaking change within v0.10.x family * Add merge type for release branch into master * 596: Update AWS SDK vendoring (#597) * 596: Update AWS SDK vendoring The vendored version of the AWS SDK is being updated to account for recent changes that have been made in the SDK. As it pertains to the issue that is being addressed, ECS ContainerDefinitions have added new properties that we should support when l0 deploys are created. * MAINT: Update broken README links * MAINT: Update v0.10.8 docs
* Release v0.10.8: Merge master into develop (#601) * Rebuild docs site post v0.10.7 release (#563) * 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) * 553: Allow Load Balancer Idle Timeout to be defined at creation time * 553: Fix breaking unit tests on idle timeout type casting * 553: Add update idle timeout cli functionality * 553: More work on fixing unit tests * 553: Fix command unit test, add printer unit test * 553: Fix remaining unit tests, add documentation * 553: Remove ELB references in docs and some review changes * 553: Make idletimeout subcommand print if no update is required * 553: Add additional documentation explaining what the Idle Timeout it * 553: Remove unnecessary import statement in elb provider decorator * 553: Make review fixes, dereferencing IdleTimeout, add more explicit error handle in lb attrib describe * 553: Modify load balancer command to ParseInt timeout rather than Atoi conversion * 533: Change spacing in cli reference docs page * Sync develop and master - v0.10.7 release (#561) * Merge for CI testing. (#527) * v0.10.4 docfixes tlake (#492) * Fixes in guides/ and reference/ * Update admonition * Remove deprecated 'apply-smoketest' target * Remove smoketests from CI pipeline * Code review updates * Clean up deprecated smoketest targets * Update docs * Update release notes and add script to update version (#495) * Update release notes and add script to update version * Add make script for updating release * Update release notes * Update travis with github release * Update travis * Test travis * Update travis * Fix travis * Update travis to build binaries for github * Update travis build and rework release flow * Move to expenv and removed release notes, reduntant * Update release notes with new flow * PR Feedback changes, fix makefile * Fix .zip missing in index * Remove l0_version * Remove dependency for prefix v * PR Feedback changes' * Fix regex * Update to v0.10.5 for docs and back expenv * Fix travis script * Update travis script * Update travis script * Update travis script * Fix travis script order * Fix docker env in travis * Fix docker login * Add expenv to before_deploy * Updated docs for v0.10.6 * Release v0.10.7 (#560) * 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) Adds CLI functionality for l0 loadbalancer create and a new subcommand l0 loadbalancer idletimeout. Create has a new optional flag --idle-timeout for create which can be used to specify the Idle Timeout of the load balancer at creation time. l0 loadbalancer idletimeout is an update subcommand that updates a given load balancer's idle timeout to a new value. Adds Terraform support for defining a load balancer's Idle Timeout. A new key is introduced into the resource, idle_timeout. * MAINT: Build docs for v0.10.7 release * MAINT: Doc fixes post v0.10.7 release * MAINT: Docs site rebuilt post v0.10.7 release * Document breaking change within v0.10.x family (#574) * 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) * 553: Allow Load Balancer Idle Timeout to be defined at creation time * 553: Fix breaking unit tests on idle timeout type casting * 553: Add update idle timeout cli functionality * 553: More work on fixing unit tests * 553: Fix command unit test, add printer unit test * 553: Fix remaining unit tests, add documentation * 553: Remove ELB references in docs and some review changes * 553: Make idletimeout subcommand print if no update is required * 553: Add additional documentation explaining what the Idle Timeout it * 553: Remove unnecessary import statement in elb provider decorator * 553: Make review fixes, dereferencing IdleTimeout, add more explicit error handle in lb attrib describe * 553: Modify load balancer command to ParseInt timeout rather than Atoi conversion * 533: Change spacing in cli reference docs page * Sync develop and master - v0.10.7 release (#561) * Merge for CI testing. (#527) * v0.10.4 docfixes tlake (#492) * Fixes in guides/ and reference/ * Update admonition * Remove deprecated 'apply-smoketest' target * Remove smoketests from CI pipeline * Code review updates * Clean up deprecated smoketest targets * Update docs * Update release notes and add script to update version (#495) * Update release notes and add script to update version * Add make script for updating release * Update release notes * Update travis with github release * Update travis * Test travis * Update travis * Fix travis * Update travis to build binaries for github * Update travis build and rework release flow * Move to expenv and removed release notes, reduntant * Update release notes with new flow * PR Feedback changes, fix makefile * Fix .zip missing in index * Remove l0_version * Remove dependency for prefix v * PR Feedback changes' * Fix regex * Update to v0.10.5 for docs and back expenv * Fix travis script * Update travis script * Update travis script * Update travis script * Fix travis script order * Fix docker env in travis * Fix docker login * Add expenv to before_deploy * Updated docs for v0.10.6 * Release v0.10.7 (#560) * 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) Adds CLI functionality for l0 loadbalancer create and a new subcommand l0 loadbalancer idletimeout. Create has a new optional flag --idle-timeout for create which can be used to specify the Idle Timeout of the load balancer at creation time. l0 loadbalancer idletimeout is an update subcommand that updates a given load balancer's idle timeout to a new value. Adds Terraform support for defining a load balancer's Idle Timeout. A new key is introduced into the resource, idle_timeout. * MAINT: Build docs for v0.10.7 release * MAINT: Doc fixes post v0.10.7 release * MAINT: Docs site rebuilt post v0.10.7 release * Document breaking change within v0.10.x family * Add merge type for release branch into master * 596: Update AWS SDK vendoring (#597) * 596: Update AWS SDK vendoring The vendored version of the AWS SDK is being updated to account for recent changes that have been made in the SDK. As it pertains to the issue that is being addressed, ECS ContainerDefinitions have added new properties that we should support when l0 deploys are created. * MAINT: Update broken README links * MAINT: Update v0.10.8 docs * use home dir for terraform plugin `~/.terraform.d/plugins` rather than arbitrary install directory * Capping AWS provider to pre-2.0 versions (#633) * 4887: Maintenance (#634) * Fix %d <-> string mismatch errors * Bump aws provider version to >= 2.0.0 * Add 'owners' to aws_ami data sources * Add request_payer to s3 bucket * Add autoscaling to read capacity of dynamodb tables * Update max_capacity * Pin version to also be < 3.0.0 * Update docs for v0.10.10 release * Change ~ to $HOME in docs
* Release v0.10.8: Merge master into develop (#601) * Rebuild docs site post v0.10.7 release (#563) * 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) * 553: Allow Load Balancer Idle Timeout to be defined at creation time * 553: Fix breaking unit tests on idle timeout type casting * 553: Add update idle timeout cli functionality * 553: More work on fixing unit tests * 553: Fix command unit test, add printer unit test * 553: Fix remaining unit tests, add documentation * 553: Remove ELB references in docs and some review changes * 553: Make idletimeout subcommand print if no update is required * 553: Add additional documentation explaining what the Idle Timeout it * 553: Remove unnecessary import statement in elb provider decorator * 553: Make review fixes, dereferencing IdleTimeout, add more explicit error handle in lb attrib describe * 553: Modify load balancer command to ParseInt timeout rather than Atoi conversion * 533: Change spacing in cli reference docs page * Sync develop and master - v0.10.7 release (#561) * Merge for CI testing. (#527) * v0.10.4 docfixes tlake (#492) * Fixes in guides/ and reference/ * Update admonition * Remove deprecated 'apply-smoketest' target * Remove smoketests from CI pipeline * Code review updates * Clean up deprecated smoketest targets * Update docs * Update release notes and add script to update version (#495) * Update release notes and add script to update version * Add make script for updating release * Update release notes * Update travis with github release * Update travis * Test travis * Update travis * Fix travis * Update travis to build binaries for github * Update travis build and rework release flow * Move to expenv and removed release notes, reduntant * Update release notes with new flow * PR Feedback changes, fix makefile * Fix .zip missing in index * Remove l0_version * Remove dependency for prefix v * PR Feedback changes' * Fix regex * Update to v0.10.5 for docs and back expenv * Fix travis script * Update travis script * Update travis script * Update travis script * Fix travis script order * Fix docker env in travis * Fix docker login * Add expenv to before_deploy * Updated docs for v0.10.6 * Release v0.10.7 (#560) * 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) Adds CLI functionality for l0 loadbalancer create and a new subcommand l0 loadbalancer idletimeout. Create has a new optional flag --idle-timeout for create which can be used to specify the Idle Timeout of the load balancer at creation time. l0 loadbalancer idletimeout is an update subcommand that updates a given load balancer's idle timeout to a new value. Adds Terraform support for defining a load balancer's Idle Timeout. A new key is introduced into the resource, idle_timeout. * MAINT: Build docs for v0.10.7 release * MAINT: Doc fixes post v0.10.7 release * MAINT: Docs site rebuilt post v0.10.7 release * Document breaking change within v0.10.x family (#574) * 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) * 553: Allow Load Balancer Idle Timeout to be defined at creation time * 553: Fix breaking unit tests on idle timeout type casting * 553: Add update idle timeout cli functionality * 553: More work on fixing unit tests * 553: Fix command unit test, add printer unit test * 553: Fix remaining unit tests, add documentation * 553: Remove ELB references in docs and some review changes * 553: Make idletimeout subcommand print if no update is required * 553: Add additional documentation explaining what the Idle Timeout it * 553: Remove unnecessary import statement in elb provider decorator * 553: Make review fixes, dereferencing IdleTimeout, add more explicit error handle in lb attrib describe * 553: Modify load balancer command to ParseInt timeout rather than Atoi conversion * 533: Change spacing in cli reference docs page * Sync develop and master - v0.10.7 release (#561) * Merge for CI testing. (#527) * v0.10.4 docfixes tlake (#492) * Fixes in guides/ and reference/ * Update admonition * Remove deprecated 'apply-smoketest' target * Remove smoketests from CI pipeline * Code review updates * Clean up deprecated smoketest targets * Update docs * Update release notes and add script to update version (#495) * Update release notes and add script to update version * Add make script for updating release * Update release notes * Update travis with github release * Update travis * Test travis * Update travis * Fix travis * Update travis to build binaries for github * Update travis build and rework release flow * Move to expenv and removed release notes, reduntant * Update release notes with new flow * PR Feedback changes, fix makefile * Fix .zip missing in index * Remove l0_version * Remove dependency for prefix v * PR Feedback changes' * Fix regex * Update to v0.10.5 for docs and back expenv * Fix travis script * Update travis script * Update travis script * Update travis script * Fix travis script order * Fix docker env in travis * Fix docker login * Add expenv to before_deploy * Updated docs for v0.10.6 * Release v0.10.7 (#560) * 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) Adds CLI functionality for l0 loadbalancer create and a new subcommand l0 loadbalancer idletimeout. Create has a new optional flag --idle-timeout for create which can be used to specify the Idle Timeout of the load balancer at creation time. l0 loadbalancer idletimeout is an update subcommand that updates a given load balancer's idle timeout to a new value. Adds Terraform support for defining a load balancer's Idle Timeout. A new key is introduced into the resource, idle_timeout. * MAINT: Build docs for v0.10.7 release * MAINT: Doc fixes post v0.10.7 release * MAINT: Docs site rebuilt post v0.10.7 release * Document breaking change within v0.10.x family * Add merge type for release branch into master * 596: Update AWS SDK vendoring (#597) * 596: Update AWS SDK vendoring The vendored version of the AWS SDK is being updated to account for recent changes that have been made in the SDK. As it pertains to the issue that is being addressed, ECS ContainerDefinitions have added new properties that we should support when l0 deploys are created. * MAINT: Update broken README links * MAINT: Update v0.10.8 docs * use home dir for terraform plugin `~/.terraform.d/plugins` rather than arbitrary install directory * Capping AWS provider to pre-2.0 versions (#633) * 4887: Maintenance (#634) * Fix %d <-> string mismatch errors * Bump aws provider version to >= 2.0.0 * Add 'owners' to aws_ami data sources * Add request_payer to s3 bucket * Add autoscaling to read capacity of dynamodb tables * Update max_capacity * Pin version to also be < 3.0.0 * Replace user-specific access token with deploy key stored in travis env var * Update docs-src release process to add new releases at top of releases table * Build layer0/docs on release
* Release v0.10.8: Merge master into develop (#601) * Rebuild docs site post v0.10.7 release (#563) * 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) * 553: Allow Load Balancer Idle Timeout to be defined at creation time * 553: Fix breaking unit tests on idle timeout type casting * 553: Add update idle timeout cli functionality * 553: More work on fixing unit tests * 553: Fix command unit test, add printer unit test * 553: Fix remaining unit tests, add documentation * 553: Remove ELB references in docs and some review changes * 553: Make idletimeout subcommand print if no update is required * 553: Add additional documentation explaining what the Idle Timeout it * 553: Remove unnecessary import statement in elb provider decorator * 553: Make review fixes, dereferencing IdleTimeout, add more explicit error handle in lb attrib describe * 553: Modify load balancer command to ParseInt timeout rather than Atoi conversion * 533: Change spacing in cli reference docs page * Sync develop and master - v0.10.7 release (#561) * Merge for CI testing. (#527) * v0.10.4 docfixes tlake (#492) * Fixes in guides/ and reference/ * Update admonition * Remove deprecated 'apply-smoketest' target * Remove smoketests from CI pipeline * Code review updates * Clean up deprecated smoketest targets * Update docs * Update release notes and add script to update version (#495) * Update release notes and add script to update version * Add make script for updating release * Update release notes * Update travis with github release * Update travis * Test travis * Update travis * Fix travis * Update travis to build binaries for github * Update travis build and rework release flow * Move to expenv and removed release notes, reduntant * Update release notes with new flow * PR Feedback changes, fix makefile * Fix .zip missing in index * Remove l0_version * Remove dependency for prefix v * PR Feedback changes' * Fix regex * Update to v0.10.5 for docs and back expenv * Fix travis script * Update travis script * Update travis script * Update travis script * Fix travis script order * Fix docker env in travis * Fix docker login * Add expenv to before_deploy * Updated docs for v0.10.6 * Release v0.10.7 (#560) * 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) Adds CLI functionality for l0 loadbalancer create and a new subcommand l0 loadbalancer idletimeout. Create has a new optional flag --idle-timeout for create which can be used to specify the Idle Timeout of the load balancer at creation time. l0 loadbalancer idletimeout is an update subcommand that updates a given load balancer's idle timeout to a new value. Adds Terraform support for defining a load balancer's Idle Timeout. A new key is introduced into the resource, idle_timeout. * MAINT: Build docs for v0.10.7 release * MAINT: Doc fixes post v0.10.7 release * MAINT: Docs site rebuilt post v0.10.7 release * Document breaking change within v0.10.x family (#574) * 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) * 553: Allow Load Balancer Idle Timeout to be defined at creation time * 553: Fix breaking unit tests on idle timeout type casting * 553: Add update idle timeout cli functionality * 553: More work on fixing unit tests * 553: Fix command unit test, add printer unit test * 553: Fix remaining unit tests, add documentation * 553: Remove ELB references in docs and some review changes * 553: Make idletimeout subcommand print if no update is required * 553: Add additional documentation explaining what the Idle Timeout it * 553: Remove unnecessary import statement in elb provider decorator * 553: Make review fixes, dereferencing IdleTimeout, add more explicit error handle in lb attrib describe * 553: Modify load balancer command to ParseInt timeout rather than Atoi conversion * 533: Change spacing in cli reference docs page * Sync develop and master - v0.10.7 release (#561) * Merge for CI testing. (#527) * v0.10.4 docfixes tlake (#492) * Fixes in guides/ and reference/ * Update admonition * Remove deprecated 'apply-smoketest' target * Remove smoketests from CI pipeline * Code review updates * Clean up deprecated smoketest targets * Update docs * Update release notes and add script to update version (#495) * Update release notes and add script to update version * Add make script for updating release * Update release notes * Update travis with github release * Update travis * Test travis * Update travis * Fix travis * Update travis to build binaries for github * Update travis build and rework release flow * Move to expenv and removed release notes, reduntant * Update release notes with new flow * PR Feedback changes, fix makefile * Fix .zip missing in index * Remove l0_version * Remove dependency for prefix v * PR Feedback changes' * Fix regex * Update to v0.10.5 for docs and back expenv * Fix travis script * Update travis script * Update travis script * Update travis script * Fix travis script order * Fix docker env in travis * Fix docker login * Add expenv to before_deploy * Updated docs for v0.10.6 * Release v0.10.7 (#560) * 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) Adds CLI functionality for l0 loadbalancer create and a new subcommand l0 loadbalancer idletimeout. Create has a new optional flag --idle-timeout for create which can be used to specify the Idle Timeout of the load balancer at creation time. l0 loadbalancer idletimeout is an update subcommand that updates a given load balancer's idle timeout to a new value. Adds Terraform support for defining a load balancer's Idle Timeout. A new key is introduced into the resource, idle_timeout. * MAINT: Build docs for v0.10.7 release * MAINT: Doc fixes post v0.10.7 release * MAINT: Docs site rebuilt post v0.10.7 release * Document breaking change within v0.10.x family * Add merge type for release branch into master * 596: Update AWS SDK vendoring (#597) * 596: Update AWS SDK vendoring The vendored version of the AWS SDK is being updated to account for recent changes that have been made in the SDK. As it pertains to the issue that is being addressed, ECS ContainerDefinitions have added new properties that we should support when l0 deploys are created. * MAINT: Update broken README links * MAINT: Update v0.10.8 docs * use home dir for terraform plugin `~/.terraform.d/plugins` rather than arbitrary install directory * Capping AWS provider to pre-2.0 versions (#633) * 4887: Maintenance (#634) * Fix %d <-> string mismatch errors * Bump aws provider version to >= 2.0.0 * Add 'owners' to aws_ami data sources * Add request_payer to s3 bucket * Add autoscaling to read capacity of dynamodb tables * Update max_capacity * Pin version to also be < 3.0.0 * Rev go version to 1.12 * Use personal access token for carbon-bot-user * Update README, CI automation in prep for relocating docs to separate repo * Move docs to separate layer0-docs repo * Fix nesting typo
* Release v0.10.8: Merge master into develop (#601) * Rebuild docs site post v0.10.7 release (#563) * 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) * 553: Allow Load Balancer Idle Timeout to be defined at creation time * 553: Fix breaking unit tests on idle timeout type casting * 553: Add update idle timeout cli functionality * 553: More work on fixing unit tests * 553: Fix command unit test, add printer unit test * 553: Fix remaining unit tests, add documentation * 553: Remove ELB references in docs and some review changes * 553: Make idletimeout subcommand print if no update is required * 553: Add additional documentation explaining what the Idle Timeout it * 553: Remove unnecessary import statement in elb provider decorator * 553: Make review fixes, dereferencing IdleTimeout, add more explicit error handle in lb attrib describe * 553: Modify load balancer command to ParseInt timeout rather than Atoi conversion * 533: Change spacing in cli reference docs page * Sync develop and master - v0.10.7 release (#561) * Merge for CI testing. (#527) * v0.10.4 docfixes tlake (#492) * Fixes in guides/ and reference/ * Update admonition * Remove deprecated 'apply-smoketest' target * Remove smoketests from CI pipeline * Code review updates * Clean up deprecated smoketest targets * Update docs * Update release notes and add script to update version (#495) * Update release notes and add script to update version * Add make script for updating release * Update release notes * Update travis with github release * Update travis * Test travis * Update travis * Fix travis * Update travis to build binaries for github * Update travis build and rework release flow * Move to expenv and removed release notes, reduntant * Update release notes with new flow * PR Feedback changes, fix makefile * Fix .zip missing in index * Remove l0_version * Remove dependency for prefix v * PR Feedback changes' * Fix regex * Update to v0.10.5 for docs and back expenv * Fix travis script * Update travis script * Update travis script * Update travis script * Fix travis script order * Fix docker env in travis * Fix docker login * Add expenv to before_deploy * Updated docs for v0.10.6 * Release v0.10.7 (#560) * 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) Adds CLI functionality for l0 loadbalancer create and a new subcommand l0 loadbalancer idletimeout. Create has a new optional flag --idle-timeout for create which can be used to specify the Idle Timeout of the load balancer at creation time. l0 loadbalancer idletimeout is an update subcommand that updates a given load balancer's idle timeout to a new value. Adds Terraform support for defining a load balancer's Idle Timeout. A new key is introduced into the resource, idle_timeout. * MAINT: Build docs for v0.10.7 release * MAINT: Doc fixes post v0.10.7 release * MAINT: Docs site rebuilt post v0.10.7 release * Document breaking change within v0.10.x family (#574) * 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) * 553: Allow Load Balancer Idle Timeout to be defined at creation time * 553: Fix breaking unit tests on idle timeout type casting * 553: Add update idle timeout cli functionality * 553: More work on fixing unit tests * 553: Fix command unit test, add printer unit test * 553: Fix remaining unit tests, add documentation * 553: Remove ELB references in docs and some review changes * 553: Make idletimeout subcommand print if no update is required * 553: Add additional documentation explaining what the Idle Timeout it * 553: Remove unnecessary import statement in elb provider decorator * 553: Make review fixes, dereferencing IdleTimeout, add more explicit error handle in lb attrib describe * 553: Modify load balancer command to ParseInt timeout rather than Atoi conversion * 533: Change spacing in cli reference docs page * Sync develop and master - v0.10.7 release (#561) * Merge for CI testing. (#527) * v0.10.4 docfixes tlake (#492) * Fixes in guides/ and reference/ * Update admonition * Remove deprecated 'apply-smoketest' target * Remove smoketests from CI pipeline * Code review updates * Clean up deprecated smoketest targets * Update docs * Update release notes and add script to update version (#495) * Update release notes and add script to update version * Add make script for updating release * Update release notes * Update travis with github release * Update travis * Test travis * Update travis * Fix travis * Update travis to build binaries for github * Update travis build and rework release flow * Move to expenv and removed release notes, reduntant * Update release notes with new flow * PR Feedback changes, fix makefile * Fix .zip missing in index * Remove l0_version * Remove dependency for prefix v * PR Feedback changes' * Fix regex * Update to v0.10.5 for docs and back expenv * Fix travis script * Update travis script * Update travis script * Update travis script * Fix travis script order * Fix docker env in travis * Fix docker login * Add expenv to before_deploy * Updated docs for v0.10.6 * Release v0.10.7 (#560) * 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) Adds CLI functionality for l0 loadbalancer create and a new subcommand l0 loadbalancer idletimeout. Create has a new optional flag --idle-timeout for create which can be used to specify the Idle Timeout of the load balancer at creation time. l0 loadbalancer idletimeout is an update subcommand that updates a given load balancer's idle timeout to a new value. Adds Terraform support for defining a load balancer's Idle Timeout. A new key is introduced into the resource, idle_timeout. * MAINT: Build docs for v0.10.7 release * MAINT: Doc fixes post v0.10.7 release * MAINT: Docs site rebuilt post v0.10.7 release * Document breaking change within v0.10.x family * Add merge type for release branch into master * 596: Update AWS SDK vendoring (#597) * 596: Update AWS SDK vendoring The vendored version of the AWS SDK is being updated to account for recent changes that have been made in the SDK. As it pertains to the issue that is being addressed, ECS ContainerDefinitions have added new properties that we should support when l0 deploys are created. * MAINT: Update broken README links * MAINT: Update v0.10.8 docs * use home dir for terraform plugin `~/.terraform.d/plugins` rather than arbitrary install directory * Capping AWS provider to pre-2.0 versions (#633) * 4887: Maintenance (#634) * Fix %d <-> string mismatch errors * Bump aws provider version to >= 2.0.0 * Add 'owners' to aws_ami data sources * Add request_payer to s3 bucket * Add autoscaling to read capacity of dynamodb tables * Update max_capacity * Pin version to also be < 3.0.0 * Rev go version to 1.12 * Use personal access token for carbon-bot-user * Update README, CI automation in prep for relocating docs to separate repo * Move docs to separate layer0-docs repo * Fix nesting typo * Properly encode carbon-bot-user access token * Add doc note about bot user access token
* Release v0.10.8: Merge master into develop (#601) * Rebuild docs site post v0.10.7 release (#563) * 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) * 553: Allow Load Balancer Idle Timeout to be defined at creation time * 553: Fix breaking unit tests on idle timeout type casting * 553: Add update idle timeout cli functionality * 553: More work on fixing unit tests * 553: Fix command unit test, add printer unit test * 553: Fix remaining unit tests, add documentation * 553: Remove ELB references in docs and some review changes * 553: Make idletimeout subcommand print if no update is required * 553: Add additional documentation explaining what the Idle Timeout it * 553: Remove unnecessary import statement in elb provider decorator * 553: Make review fixes, dereferencing IdleTimeout, add more explicit error handle in lb attrib describe * 553: Modify load balancer command to ParseInt timeout rather than Atoi conversion * 533: Change spacing in cli reference docs page * Sync develop and master - v0.10.7 release (#561) * Merge for CI testing. (#527) * v0.10.4 docfixes tlake (#492) * Fixes in guides/ and reference/ * Update admonition * Remove deprecated 'apply-smoketest' target * Remove smoketests from CI pipeline * Code review updates * Clean up deprecated smoketest targets * Update docs * Update release notes and add script to update version (#495) * Update release notes and add script to update version * Add make script for updating release * Update release notes * Update travis with github release * Update travis * Test travis * Update travis * Fix travis * Update travis to build binaries for github * Update travis build and rework release flow * Move to expenv and removed release notes, reduntant * Update release notes with new flow * PR Feedback changes, fix makefile * Fix .zip missing in index * Remove l0_version * Remove dependency for prefix v * PR Feedback changes' * Fix regex * Update to v0.10.5 for docs and back expenv * Fix travis script * Update travis script * Update travis script * Update travis script * Fix travis script order * Fix docker env in travis * Fix docker login * Add expenv to before_deploy * Updated docs for v0.10.6 * Release v0.10.7 (#560) * 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) Adds CLI functionality for l0 loadbalancer create and a new subcommand l0 loadbalancer idletimeout. Create has a new optional flag --idle-timeout for create which can be used to specify the Idle Timeout of the load balancer at creation time. l0 loadbalancer idletimeout is an update subcommand that updates a given load balancer's idle timeout to a new value. Adds Terraform support for defining a load balancer's Idle Timeout. A new key is introduced into the resource, idle_timeout. * MAINT: Build docs for v0.10.7 release * MAINT: Doc fixes post v0.10.7 release * MAINT: Docs site rebuilt post v0.10.7 release * Document breaking change within v0.10.x family (#574) * 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) * 553: Allow Load Balancer Idle Timeout to be defined at creation time * 553: Fix breaking unit tests on idle timeout type casting * 553: Add update idle timeout cli functionality * 553: More work on fixing unit tests * 553: Fix command unit test, add printer unit test * 553: Fix remaining unit tests, add documentation * 553: Remove ELB references in docs and some review changes * 553: Make idletimeout subcommand print if no update is required * 553: Add additional documentation explaining what the Idle Timeout it * 553: Remove unnecessary import statement in elb provider decorator * 553: Make review fixes, dereferencing IdleTimeout, add more explicit error handle in lb attrib describe * 553: Modify load balancer command to ParseInt timeout rather than Atoi conversion * 533: Change spacing in cli reference docs page * Sync develop and master - v0.10.7 release (#561) * Merge for CI testing. (#527) * v0.10.4 docfixes tlake (#492) * Fixes in guides/ and reference/ * Update admonition * Remove deprecated 'apply-smoketest' target * Remove smoketests from CI pipeline * Code review updates * Clean up deprecated smoketest targets * Update docs * Update release notes and add script to update version (#495) * Update release notes and add script to update version * Add make script for updating release * Update release notes * Update travis with github release * Update travis * Test travis * Update travis * Fix travis * Update travis to build binaries for github * Update travis build and rework release flow * Move to expenv and removed release notes, reduntant * Update release notes with new flow * PR Feedback changes, fix makefile * Fix .zip missing in index * Remove l0_version * Remove dependency for prefix v * PR Feedback changes' * Fix regex * Update to v0.10.5 for docs and back expenv * Fix travis script * Update travis script * Update travis script * Update travis script * Fix travis script order * Fix docker env in travis * Fix docker login * Add expenv to before_deploy * Updated docs for v0.10.6 * Release v0.10.7 (#560) * 549: Fix API service LB health check for v0.10.6 (#550) When running l0-setup apply for a new instance, after the resources are created, the health check was not succeeding and timing out. This happened because l0-setup tries to hit /health while the API was coded to have the health endpoint on /admin/health. This change was originally implemented in api-refactor branches, so we are applying the /admin/helth -> /health change to the master/develop branches * 553: Support ELB Idle Timeout in CLI and Terraform when creating or updating load balancer (#557) Adds CLI functionality for l0 loadbalancer create and a new subcommand l0 loadbalancer idletimeout. Create has a new optional flag --idle-timeout for create which can be used to specify the Idle Timeout of the load balancer at creation time. l0 loadbalancer idletimeout is an update subcommand that updates a given load balancer's idle timeout to a new value. Adds Terraform support for defining a load balancer's Idle Timeout. A new key is introduced into the resource, idle_timeout. * MAINT: Build docs for v0.10.7 release * MAINT: Doc fixes post v0.10.7 release * MAINT: Docs site rebuilt post v0.10.7 release * Document breaking change within v0.10.x family * Add merge type for release branch into master * 596: Update AWS SDK vendoring (#597) * 596: Update AWS SDK vendoring The vendored version of the AWS SDK is being updated to account for recent changes that have been made in the SDK. As it pertains to the issue that is being addressed, ECS ContainerDefinitions have added new properties that we should support when l0 deploys are created. * MAINT: Update broken README links * MAINT: Update v0.10.8 docs * use home dir for terraform plugin `~/.terraform.d/plugins` rather than arbitrary install directory * Capping AWS provider to pre-2.0 versions (#633) * 4887: Maintenance (#634) * Fix %d <-> string mismatch errors * Bump aws provider version to >= 2.0.0 * Add 'owners' to aws_ami data sources * Add request_payer to s3 bucket * Add autoscaling to read capacity of dynamodb tables * Update max_capacity * Pin version to also be < 3.0.0 * Rev go version to 1.12 * Use personal access token for carbon-bot-user * Update README, CI automation in prep for relocating docs to separate repo * Move docs to separate layer0-docs repo * Fix nesting typo * Properly encode carbon-bot-user access token * Add doc note about bot user access token * 642: Cross-Zone Load Balancing Management (#643) * Add cross-zone management * Generate mocks and decorators * Update axios version * Enable cross-zone by default on load balancer creation * Add cross-zone to load balancer attributes * Add cross-zone to terraform data source * Manual mock udpate * Add cross-zone unittests * Add cross-zone smoke tests * Fix typos in load balancer cross-zone smoketests
What does this pull request do?
Adds CLI functionality for
l0 loadbalancer create
and a new subcommandl0 loadbalancer idletimeout
. Create has a new optional flag--idle-timeout
for create which can be used to specify the Idle Timeout of the load balancer at creation time.l0 loadbalancer idletimeout
is an update subcommand that updates a given load balancer's idle timeout to a new value.Adds Terraform support for defining a load balancer's Idle Timeout. A new key is introduced into the resource,
idle_timeout
.How should this be tested?
Manually via the CLI:
l0 loadbalancer create env_a lb_a --idle-timeout 100
andl0 loadbalancer idletimeout lb_a 200
Via terraform:
Apply, then change idle_timeout and apply again.
Unit tests have been created and they should pass. Documentation has been updated to reflect these changes.
Checklist
- [ ] Smoke tests (if applicable)- [ ] System tests (if applicable)closes #553