Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to newer major versions #551

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

mirekdlugosz
Copy link
Collaborator

While debugging Playwright failures the other week, I noticed we have old pytest-playwright version (which is separate project from playwright). While I was at it, I decided to update other tools as well. I've looked at changelogs to see if there are any changes we should be aware of.

I trust poetry show -o -T to tell me what we need to update.

I've ran that locally and got few failures in camayoc/tests/qpc/cli/test_sources.py::test_clear_all. I think these are caused by my environment not being clean, but we'll see what Jenkins has to say.

Changes outside of .pre-commit-config.yaml, poetry.lock and pyproject.toml are done automatically by ruff. They introduced new formatting rules since last version we have used.

@mirekdlugosz mirekdlugosz requested review from a team November 25, 2024 17:27
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.85%. Comparing base (1e734f6) to head (6e1b638).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #551   +/-   ##
=======================================
  Coverage   76.85%   76.85%           
=======================================
  Files           7        7           
  Lines         700      700           
=======================================
  Hits          538      538           
  Misses        162      162           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Changes outside of .pre-commit-config.yaml, poetry.lock and
pyproject.toml are done automatically by ruff. They introduced new
formatting rules since last version we have used.
@mirekdlugosz mirekdlugosz force-pushed the update-dependencies-20241125 branch from f0ed9a1 to 6e1b638 Compare November 26, 2024 16:21
@mirekdlugosz
Copy link
Collaborator Author

As discussed on Slack and standup, I removed pytest 8 upgrade due to issue it caused on standalone job. Upgrading pytest is covered by DISCOVERY-863 as relatively low priority thing to do.

@mirekdlugosz mirekdlugosz merged commit a855261 into main Nov 26, 2024
11 checks passed
@mirekdlugosz mirekdlugosz deleted the update-dependencies-20241125 branch November 26, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants