Remove support for UI v1 #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is semi-reversal of commits introduced in GitHub PR #543. All the conditionals around `use_uiv2` setting are dropped. What used to be inside conditional is now unversioned path, while what used to be v1 path is now removed (this applies mainly to field definitions and values). This commit leaves around a bit of dead code that is going to be removed in subsequent commits.
UIv2 does not use wizard component. Remove support for it from Camayoc. This allows us to simplify AddSourceDTO, as now it can hold source type directly - earlier it had to hold special DTO that only had source type, because each AddSourceDTO parameter mapped to wizard step.
Other action DTO classes (AddSourceDTO, TriggerScanDTO) use just _form attribute names, without _dto suffix. AddCredentialDTO was the only one standing out.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #555 +/- ##
=======================================
Coverage 76.85% 76.85%
=======================================
Files 7 7
Lines 700 700
=======================================
Hits 538 538
Misses 162 162 ☔ View full report in Codecov by Sentry. |
infinitewarp
approved these changes
Dec 11, 2024
ruda
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that new UI is available both upstream and downstream, we can remove traces of old UI.
The main thing is removing conditionals around
use_uiv2setting, and promoting what used to be behind conditional to be the only path. With that out of the way, we can also fixLogin.login()to stop navigating to sources and drop Wizard component. The last part also allows us to simplify DTOs (source DTO was following a pattern where each attribute mapped to single step of wizard modal). Finally, I put one consistency fix I noticed while working on all that.See individual commit messages for details. I would prefer to not squash them during merge.