Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NodeJS LTS 20 Support #5989

Closed
jpdied opened this issue Dec 7, 2023 · 1 comment · Fixed by #5990
Closed

NodeJS LTS 20 Support #5989

jpdied opened this issue Dec 7, 2023 · 1 comment · Fixed by #5990
Labels
enhancement

Comments

@jpdied
Copy link

jpdied commented Dec 7, 2023

NodeJS 18 LTS ended active support over a month ago although it still is receiving security updates. Node is pushing 20 LTS now on their website and on Windows, the winget package manager is actively trying to upgrade 18 to 20.

I propose adding support for the current mainstream v20 LTS.

When trying to set things up with 20, you get the following:

$ npm install
npm ERR! code EBADENGINE
npm ERR! engine Unsupported engine
npm ERR! engine Not compatible with your version of node/npm: [email protected]
npm ERR! notsup Not compatible with your version of node/npm: [email protected]
npm ERR! notsup Required: {"node":">=18.10.0 <=18.18.2"}
npm ERR! notsup Actual:   {"npm":"10.2.3","node":"v20.10.0"}
@quisquous
Copy link
Owner

Yeah, this is a duplicate of #5910. Github has been switching over slowly today and jobs have been intermittently failing. I think I have something that should work, but need to make sure it works on both 18 and 20.

I'm going to close this as a duplicate of that other issue.

quisquous added a commit that referenced this issue Dec 7, 2023
@quisquous
build: add back loader parameter to node commands
6b2279a 
Instead of:
  `ts-node util/sync_files.ts`
Now we must do:
  `node --loader=ts-node/esm util/sync_files.ts`

Additionally, as `--loader` is deprecated, an error message
suggests to do in JavaScript, so add a loader script
`--import ./loader.js` to do this work instead

Fixes #5910.
Fixes #5989.
@quisquous quisquous mentioned this issue Dec 7, 2023
Merged
quisquous added a commit that referenced this issue Dec 20, 2023
@quisquous
build: switch to node 20, add back loader param (#5990)
4c5cf21 
Instead of:
  `ts-node util/sync_files.ts`
Now we must do:
  `node --loader=ts-node/esm util/sync_files.ts`

This should work on both node 18 and node 20 (tested locally).

Git workflows were pinned to 18.18.2 via #5991, but are now updated to
20 for constency. It's possible that ts-node will fix this in the future
and we can remove (again) the loader param.

Fixes #5910.
Fixes #5989.
github-actions bot pushed a commit that referenced this issue Dec 20, 2023
triggers build: build: switch to node 20, add back loader param (#5990)
64f460b 
Instead of:
  `ts-node util/sync_files.ts`
Now we must do:
  `node --loader=ts-node/esm util/sync_files.ts`

This should work on both node 18 and node 20 (tested locally).

Git workflows were pinned to 18.18.2 via #5991, but are now updated to
20 for constency. It's possible that ts-node will fix this in the future
and we can remove (again) the loader param.

Fixes #5910.
Fixes #5989. 4c5cf21
github-actions bot pushed a commit that referenced this issue Dec 20, 2023
gh-pages build: build: switch to node 20, add back loader param (#5990)
abd7e75 
Instead of:
  `ts-node util/sync_files.ts`
Now we must do:
  `node --loader=ts-node/esm util/sync_files.ts`

This should work on both node 18 and node 20 (tested locally).

Git workflows were pinned to 18.18.2 via #5991, but are now updated to
20 for constency. It's possible that ts-node will fix this in the future
and we can remove (again) the loader param.

Fixes #5910.
Fixes #5989. 4c5cf21
github-actions bot pushed a commit to SiliconExarch/cactbot that referenced this issue Jan 5, 2024
gh-pages build: build: switch to node 20, add back loader param (quis…
f4e9a52 
…quous#5990)

Instead of:
  `ts-node util/sync_files.ts`
Now we must do:
  `node --loader=ts-node/esm util/sync_files.ts`

This should work on both node 18 and node 20 (tested locally).

Git workflows were pinned to 18.18.2 via quisquous#5991, but are now updated to
20 for constency. It's possible that ts-node will fix this in the future
and we can remove (again) the loader param.

Fixes quisquous#5910.
Fixes quisquous#5989. 4c5cf21
github-actions bot pushed a commit to SiliconExarch/cactbot that referenced this issue Jan 6, 2024
triggers build: build: switch to node 20, add back loader param (quis…
6fbc2f1 
…quous#5990)

Instead of:
  `ts-node util/sync_files.ts`
Now we must do:
  `node --loader=ts-node/esm util/sync_files.ts`

This should work on both node 18 and node 20 (tested locally).

Git workflows were pinned to 18.18.2 via quisquous#5991, but are now updated to
20 for constency. It's possible that ts-node will fix this in the future
and we can remove (again) the loader param.

Fixes quisquous#5910.
Fixes quisquous#5989. 4c5cf21
github-actions bot pushed a commit to SiliconExarch/cactbot that referenced this issue Jan 6, 2024
gh-pages build: build: switch to node 20, add back loader param (quis…
5092acf 
…quous#5990)

Instead of:
  `ts-node util/sync_files.ts`
Now we must do:
  `node --loader=ts-node/esm util/sync_files.ts`

This should work on both node 18 and node 20 (tested locally).

Git workflows were pinned to 18.18.2 via quisquous#5991, but are now updated to
20 for constency. It's possible that ts-node will fix this in the future
and we can remove (again) the loader param.

Fixes quisquous#5910.
Fixes quisquous#5989. 4c5cf21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: switch to node 20, add back loader param quisquous/cactbot
2 participants
@quisquous @jpdied