Skip to content

Commit

Permalink
Update: Use meta.hasSuggestions for suggestable rules to prepare for …
Browse files Browse the repository at this point in the history
…ESLint 8 (#186)

The change to require suggestable rules to have `meta.hasSuggestions` has been accepted and mentioned in the blog post for the upcoming ESLint 8 breaking changes. So we should adopt this change now to ensure we are compatible with ESLint 8 as soon as possible. The old property `meta.docs.suggestion` was unused anyway.

https://eslint.org/blog/2021/06/whats-coming-in-eslint-8.0.0#rules-with-suggestions-now-require-the-metahassuggestions-property
  • Loading branch information
bmish authored Jun 12, 2021
1 parent 7fda3c4 commit 9c8e1fd
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions lib/rules/no-assert-equal.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@ module.exports = {
docs: {
description: "disallow the use of assert.equal",
category: "Best Practices",
url: "https://github.com/platinumazure/eslint-plugin-qunit/blob/master/docs/rules/no-assert-equal.md",
suggestion: true
url: "https://github.com/platinumazure/eslint-plugin-qunit/blob/master/docs/rules/no-assert-equal.md"
},
messages: {
unexpectedGlobalEqual: "Unexpected equal. Use strictEqual, deepEqual, or propEqual.",
Expand All @@ -32,7 +31,8 @@ module.exports = {
switchToPropEqual: "Switch to propEqual.",
switchToStrictEqual: "Switch to strictEqual."
},
schema: []
schema: [],
hasSuggestions: true
},

create: function (context) {
Expand Down

0 comments on commit 9c8e1fd

Please sign in to comment.