This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
Merge registry-bootstrap-ds.yaml and registry-ds.yaml #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at doesn't create one of the daemonset Renaming it cannot resolve the registry. With current fix, using explicit declaration of bootstrap node the problem is solved.
|
Actually if both Deployments/Daemonsets uses the same set of labels and you create the according Service that selects the Pods with the according labels it should work without any problem. Anyway I think it's a good way to merge both Daemonsets for simplicity. |
|
Thanks. In that case, renaming one of the daemonset should work fine, if decided against merging. |
…egistry-bootstrap without bootstrap flag This will not crash the Pod(install_quobyte does the same).
…uobyte/registry-bootstrap without bootstrap flag" Crashing of registry is not a problem. DeviceInspector can be used to fomat device as registry once bootstrap is up and running. This reverts commit e8ca3c7.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both registry-bootstrap-ds.yaml and registry-ds.yaml uses registry as the name, this doesn't allow both to be created at the same time. Renaming one cannot resolve the registry.
Current fix relies on the explicit declaration of bootstrap node in
deploy/config.yamlto current label based approach and initializes bootstrap device when registry pod created on given bootstrap node.