Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a better fallback name for rooms #310

Closed
KitsuneRal opened this issue Mar 30, 2019 · 0 comments
Closed

Provide a better fallback name for rooms #310

KitsuneRal opened this issue Mar 30, 2019 · 0 comments
Assignees
@KitsuneRal
Labels
bug/fix The library doesn't work as expected

Comments

@KitsuneRal
Copy link
Member

Due to matrix-org/synapse#4926, direct chats abandoned by either party are named 'Empty room (Was: )', which is not correct technically (the list of heroes should be checked for emptiness before being used) and, of course, UX-wise. Somewhat similar problem is in case of invites. The library should make best effort and check the list of room members (invited and left inclusive) to provide a fallback display name in such cases.
@KitsuneRal KitsuneRal added the bug/fix The library doesn't work as expected label Mar 30, 2019
@KitsuneRal KitsuneRal self-assigned this Mar 30, 2019
KitsuneRal added a commit that referenced this issue Mar 31, 2019
@KitsuneRal
Room: track invited users; polish the room naming algorithm
7acd18f 
It's no more entirely along the spec lines but gives better results with
or without lazy-loading, across a wide range of cases. Closes #310.
@KitsuneRal KitsuneRal moved this to Version 0.5(.x) - Released in libQuotient 1 May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KitsuneRal KitsuneRal

Labels
bug/fix The library doesn't work as expected
Projects
libQuotient 1
Status: Version 0.5(.x) - Released
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KitsuneRal