Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example extensions are hard to understand #22

Closed
petebankhead opened this issue Nov 29, 2024 · 0 comments · Fixed by #23
Closed

Example extensions are hard to understand #22

petebankhead opened this issue Nov 29, 2024 · 0 comments · Fixed by #23

Comments

@petebankhead
Copy link
Member

petebankhead commented Nov 29, 2024

At some point the example extensions (especially the Java one) have become complicated and confusing.

Some issues:

  • The fxml UI is too small by default
  • The spinner changes 'threads' but it's not clear to the user if this will actually impact the functioning of the software
  • The run button doesn't seem to do anything
  • The use of string resources is inconsistent, so doesn't show best practices
  • There is no parent or title set for the dialog that is shown, so it doesn't behave like most in QuPath
  • Uses deprecated API (addPropertyItem)
  • addPreference and addPreferenceToPane do the same thing
  • More fields could be final

I think the demo should be either very minimal (e.g. show a dialog and nothing more)l, or show very clear examples of best practices (e.g. show the use of fxml and resources).

alanocallaghan added a commit to alanocallaghan/qupath-extension-template that referenced this issue Jan 10, 2025
alanocallaghan added a commit to alanocallaghan/qupath-extension-template that referenced this issue Jan 10, 2025
alanocallaghan added a commit to alanocallaghan/qupath-extension-template that referenced this issue Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant