Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate page id by the selected mushaf id #2158

Merged
merged 7 commits into from
May 19, 2024

Conversation

AhmedCodeGuy
Copy link
Collaborator

Summary

Fixes #QF-433

In creating or updating a goal the button will be disabled if the page number is outside the range of the selected Mushaf settings

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Test plan

I created and updated a goal using different Mushaf settings and the button is disabled when I type a page number that is greater than the Mushaf pages count:

  • Indopak 15 lines
  • Indopak 16 lines
  • Uthmani

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quran-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 10:37am

src/utils/validator.ts Outdated Show resolved Hide resolved
@AhmedCodeGuy AhmedCodeGuy merged commit 93d320b into testing May 19, 2024
5 checks passed
@AhmedCodeGuy AhmedCodeGuy deleted the QF-433-fix-creating-updating-a-goal-pages-limit branch May 19, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants