Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indopak translation mode missing ayahs #2166

Merged
merged 6 commits into from
Jun 20, 2024

Conversation

AhmedCodeGuy
Copy link
Collaborator

@AhmedCodeGuy AhmedCodeGuy commented Jun 9, 2024

Summary

Fixes #QF-469

Fetch page's verses data on the client to specify the select mushaf ID instead of always using the default mushaf ID which is Uthmani.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Test plan

This has been tested on chrome with different pages following this route: /page/[pageId] using Indopak, 15 lines, translation mode.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Screenshots or videos

Before After
Screenshot 2024-06-09 at 12 12 54 PM Screenshot 2024-06-09 at 12 13 08 PM

Copy link

vercel bot commented Jun 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quran-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 10:38am

@AhmedCodeGuy AhmedCodeGuy marked this pull request as ready for review June 11, 2024 08:57
src/components/QuranReader/hooks/useFetchPageVerses.ts Outdated Show resolved Hide resolved
src/pages/page/[pageId].tsx Outdated Show resolved Hide resolved
@osamasayed osamasayed merged commit 912b56c into testing Jun 20, 2024
5 checks passed
@osamasayed osamasayed deleted the QF-469-translation-mode-indopak-missing-ayahs branch June 20, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants