Update animations functionality to only support the native popover approach #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3ea0620 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
cwoolum
commented
Sep 21, 2024
| @@ -7,6 +7,7 @@ on: | |||
| jobs: | |||
| test: | |||
| runs-on: ubuntu-latest | |||
| name: Test NodeJS ${{ matrix.node_version }} | |||
There was a problem hiding this comment.
Adding this to make the actions page a bit more readable.
cwoolum
commented
Sep 21, 2024
| @@ -39,7 +39,7 @@ | |||
| "test.utils": "nx test utils" | |||
| }, | |||
| "simple-git-hooks": { | |||
| "pre-commit": "pnpm format.staged" | |||
| "pre-commit": "pnpm format.staged && pnpm lint" | |||
There was a problem hiding this comment.
Added this so that linting errors are caught before creating a PR. Let me know if this was intentionally excluded.
cwoolum
force-pushed
the
main
branch
2 times, most recently
from
41a1503 to
92bdf79
Compare
cwoolum
changed the title
maiieul
approved these changes
Oct 2, 2024
This was referenced Oct 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Why is it needed?
This closes out #913. The existing shimming to support animations has been removed and only native popover animations will be supported. We now have full documentation along with warnings for how animations should be used with the popover API.
I also updated the modal animation documentation to reflect the current state of support.
Checklist:
pnpm changeand documented my changes