Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DnD Quick Toggle (and some style changes) #24

Merged
merged 8 commits into from
Nov 4, 2022
Merged

Add DnD Quick Toggle (and some style changes) #24

merged 8 commits into from
Nov 4, 2022

Conversation

Leleat
Copy link
Contributor

@Leleat Leleat commented Nov 4, 2022

This PR adds a Do-no-Disturb Quick Toggle and moves the clear-notifications-button to the Notifications title (similiar to Libadwaita's header suffixes). Here is how it looks with GNOME Shell's default theme (on Fedora)

image

image

(The clear-notifications-button has a slight highlight when hovered.)

Some notes:

  • Should the separate notifications popup be removed entirely? It currently doesn't look very good with the styling.
  • I've renamed the 'button remover' file and references to 'quickTogglesManager' because now it doesn't 'only' remove existing quick toggles. In the future I imagine there could be more quick toggles (like a11y etc) implemented by this extension or even the ability to reorder the quick toggles.
  • Since you wanted to refactor the code anyway (Code refactoring, and improve quality of code needed #16) I've mostly tried to build on top of the existing code.

@qwreey qwreey merged commit 12a2880 into qwreey:master Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants