Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbFetch() documentation needs more documentation about overall flow #386

Closed
hadley opened this issue May 24, 2022 · 8 comments
Closed

dbFetch() documentation needs more documentation about overall flow #386

hadley opened this issue May 24, 2022 · 8 comments

Comments

@hadley
Copy link
Member

hadley commented May 24, 2022

i.e.:

  • Use dbSendQuery() to get a result set
  • Optionally bind paremeters with dbBind().
  • Use dbFetch() to get a page of results
  • Use dbHasCompleted() to tell when you're done
  • Use dbClearResult() to clean up

And it might be worth linking all these functions together with a common family.

@krlmlr
Copy link
Member

krlmlr commented May 25, 2022

Thanks. We have some material in https://dbi.r-dbi.org/articles/dbi-advanced . Would a link to vignette("dbi-advanced") be sufficient for now? Should we reorganize closer to the structure you're suggesting, or perhaps add a new text (directly to the help page and/or in a new vignette)?

@hadley
Copy link
Member Author

hadley commented May 25, 2022

I think the docs for those functions could have a shared section called something like "The dbFetch() flow" which basically included the bulleted list above + a link to the vignette. Probably should also link to dbGetQuery() as wrapper that most people will want to use.

Do you want me to propose something?

@hadley
Copy link
Member Author

hadley commented May 25, 2022

Oops, I just realised I'll filed this in the wrong repo. I'll move it.

@hadley hadley transferred this issue from r-dbi/DBItest May 25, 2022
krlmlr added a commit that referenced this issue Jun 18, 2022
@krlmlr
Copy link
Member

krlmlr commented Jun 18, 2022

Almost forgot, see d2bf235 for a proposal. Releasing today, we can tweak later.

krlmlr added a commit that referenced this issue Jun 18, 2022
@krlmlr
Copy link
Member

krlmlr commented Jun 18, 2022

Next try: 7abf906.

@krlmlr
Copy link
Member

krlmlr commented Jun 18, 2022

Done and submitted to CRAN, see https://dbi.r-dbi.org/reference/dbbind for the rendered version.

Still happy to take feedback.

CC @hannes.

@krlmlr krlmlr closed this as completed Jun 18, 2022
@hadley
Copy link
Member Author

hadley commented Jun 18, 2022

LGTM.

@github-actions
Copy link
Contributor

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants