Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema handling in default implementation of dbQuoteIdentifier #71

Closed
krlmlr opened this issue Dec 23, 2015 · 2 comments
Closed

Schema handling in default implementation of dbQuoteIdentifier #71

krlmlr opened this issue Dec 23, 2015 · 2 comments
Assignees
@krlmlr

Comments

@krlmlr
Copy link
Member

krlmlr commented Dec 23, 2015

Currently dbQuoteIdentifier() seems to be vectorized over its input, which conflicts schema support (#24) and DBItest "quote_identifier_not_vectorized".
@krlmlr
Copy link
Member Author

krlmlr commented Dec 1, 2016

No schema handling, will raise an error for length != 1.

@krlmlr krlmlr self-assigned this Dec 1, 2016
@krlmlr
Copy link
Member Author

krlmlr commented Dec 1, 2016 •
edited
Loading

Can't do that: https://travis-ci.org/rstats-db/DBI/jobs/180431797#L791. Will instead use lapply() and check that each item has length 1. This enables support for lists of characters.

@krlmlr krlmlr closed this as completed in 5d584ff Dec 2, 2016
krlmlr added a commit that referenced this issue Dec 2, 2016
@krlmlr
Merge tag 'v0.5-13'
238b676 
- Remove `valueClass = "logical"` for those generics where the return value is meaningless, to allow backends to return invisibly (#135).
- New `dbQuoteIdentifier(DBIConnection, list)` to support quoting multi-component identifiers such as tables in a schema (#71). DBI backends should implement this method for schema support.
- Renamed arguments to `sqlInterpolate()` and `sqlParseVariables()`, the former gains a `.dots` argument (#140, #147).
until RSQLite 1.1 has been built for OS X
- Remove `max.connections` requirement from documentation (#56).
- Enable `dbBind()` example (#136).
- Use roxygen2 inheritance to copy DBI specification to this package.
- Avoid using braces in the definitions of generics if possible, so that standard generics can be detected (#146).
- Change `omegahat.org` URL to `omegahat.net`, the particular document still doesn't exist below the new domain.
- Use `tic` package for building documentation.
@ghost ghost removed the in progress label Dec 2, 2016
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@krlmlr krlmlr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@krlmlr