New dbBreak() #133
Merged
New dbBreak() #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -98,6 +102,18 @@ setGeneric("dbRollback", | |||
| #' ) | |||
| #' dbReadTable(con, "cars") # still 6 rows | |||
| #' | |||
| #' ## early exit, silently | |||
| #' tryCatch( | |||
There was a problem hiding this comment.
What's the purpose of the tryCatch() here? Just to avoid a \dontrun{}?
Current coverage is 42.82% (diff: 0.00%)@@ master #133 diff @@
==========================================
Files 16 16
Lines 436 446 +10
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 191 191
- Misses 245 255 +10
Partials 0 0
|
krlmlr
added a commit
that referenced
this pull request
Aug 10, 2016
krlmlr
added a commit
that referenced
this pull request
Aug 11, 2016
- Interface changes
- `dbDataType()` maps `character` values to `"TEXT"` by default (#102).
- The default implementation of `dbQuoteString()` doesn't call `encodeString()` anymore: Neither SQLite nor Postgres understand e.g. `\n` in a string literal, and all of SQLite, Postgres, and MySQL accept an embedded newline (#121).
- Interface enhancements
- New `dbSendStatement()` generic, forwards to `dbSendQuery()` by default (#20, #132).
- New `dbExecute()`, calls `dbSendStatement()` by default (#109, @bborgesr).
- New `dbWithTransaction()` that calls `dbBegin()` and `dbCommit()`, and `dbRollback()` on failure (#110, @bborgesr).
- New `dbBreak()` function which allows aborting from within `dbWithTransaction()` (#115, #133).
- Export `dbFetch()` and `dbQuoteString()` methods.
- Documentation improvements:
- One example per function (except functions scheduled for deprecation) (#67).
- Consistent layout and identifier naming.
- Better documentation of generics by adding links to the class and related generics in the "See also" section under "Other DBI... generics" (#130). S4 documentation is directed to a hidden page to unclutter documentation index (#59).
- Fix two minor vignette typos (#124, @mdsumner).
- Add package documentation.
- Remove misleading parts in `dbConnect()` documentation (#118).
- Remove misleading link in `dbDataType()` documentation.
- Remove full stop from documentation titles.
- New help topic "DBIspec" that contains the full DBI specification (currently work in progress) (#129).
- HTML documentation generated by `staticdocs` is now uploaded to http://rstats-db.github.io/DBI for each build of the "production" branch (#131).
- Further minor changes and fixes.
- Internal
- Use `contains` argument instead of `representation()` to denote base classes (#93).
- Remove redundant declaration of transaction methods (#110, @bborgesr).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for breaking out of a transaction, and perhaps other loop constructs (#111).
Fixes #115.
CC @bborgesr, @jcheng5, @jimhester, @hadley.