-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generic dbIsReadOnly #190
Conversation
Codecov Report
@@ Coverage Diff @@
## master #190 +/- ##
=======================================
Coverage 43.34% 43.34%
=======================================
Files 16 16
Lines 466 466
=======================================
Hits 202 202
Misses 264 264
Continue to review full report at Codecov.
|
Thanks. I wonder in which situations the read-only status of an existing connection can change? |
I agree that it's unlikely for a read-only connection to change its read-only status. The generic is more of an UX improvement, e.g. confirming the read-only status whenever the user Given that an user may initiate a connection and work with it over hours, such a reminder is re-assuring. (Tagging @wlattner, in case this DBI feature is something civis-r still uses). |
Thanks, I'm happy to include it. How do you open a read-only connection to a database? Does this method also cover situations where the read-only status is due to missing write permissions? |
An user opens a read-only connection with Then, whenever the user sends a query (via Our R package doesn't deal with permission. It simply sends users' queries from R to their databases hosted on our cloud. We check permissions in the cloud. |
I wonder if we should provide a default method for Could you please also update the documentation? |
Thanks! Let's avoid a default method for now. |
From Issue #189
Closes #189