Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test backends as part of Travis-CI tests #52

Closed
krlmlr opened this issue Jan 14, 2016 · 6 comments
Closed

Test backends as part of Travis-CI tests #52

krlmlr opened this issue Jan 14, 2016 · 6 comments
Milestone

Comments

@krlmlr
Copy link
Member

krlmlr commented Jan 14, 2016

in parallel, triggered by environment variable

@krlmlr krlmlr added this to the 1.1 milestone Jan 14, 2016
@krlmlr
Copy link
Member Author

krlmlr commented Jan 14, 2016

@hannesmuehleisen: How do I test stable/bleeding-edge versions of MonetDB.R and MonetDBLite in Travis?

@marcelboldt: I see in https://github.com/EXASOL/r-exasol that you are already testing on Travis. Are you aware of the recent RODBCDBI package by @teramonagi?

@hannes
Copy link

hannes commented Jan 14, 2016

@krlmlr Travis?

@krlmlr
Copy link
Member Author

krlmlr commented Jan 14, 2016

@hannesmuehleisen: Basically, I'm looking for an unanttended install of the database engine on an Ubuntu 12.04 (14.04) box with root access, and for a script to download sources for the bleeding-edge version of MonetDB.R and MonetDBLite.

@hannes
Copy link

hannes commented Jan 14, 2016

Ok, bleeding install for MonetDB.R/MonetDBLite:

install.packages(c("MonetDB.R", "MonetDBLite"), repos=c("http://dev.monetdb.org/Assets/R/", "http://cran.rstudio.com/"))

For MonetDB on Ubuntu, we have packages, see https://www.monetdb.org/downloads/deb/

@hadley
Copy link
Member

hadley commented Jan 26, 2016

It feels like testing should be job of the individual backends. I think the way we encourage the use of the tests is through a DBI-backend scorecard website or similar.

@hadley
Copy link
Member

hadley commented Jan 26, 2016

Ok - this is for testing DBItest, not for testing the backends.

@krlmlr krlmlr closed this as completed in 3fb96f9 Jan 29, 2016
krlmlr pushed a commit that referenced this issue Feb 4, 2016
- Test `RPostgres`, `RMySQL`, `RSQLite` and `RKazam` as part of the Travis-CI tests (#52).
- Stress test now installs package in temporary library before loading DBI (r-dbi/RSQLite#128).
- `make_context()` now works again if `tweaks` arg is omitted (regression introduced in 1.0-3).
- Expect a warning instead of an error for double disconnect (#50).
- Move connection test that requires `dbFetch()` to `test_result()`.
krlmlr pushed a commit that referenced this issue Feb 12, 2016
- New feature: tweaks
    - New argument `tweaks` to `make_context()` (#49).
    - New `tweaks()`, essentially constructs a named list of tweaks but with predefined and documented argument names.
    - `constructor_name`, respected by the `constructor.*` tests.
    - `strict_identifier`, if `TRUE` all identifier must be syntactic names even if quoted. The quoting test is now split, and a part is ignored conditional to this tweak. The `roundtrip_quotes` tests also respects this tweak.
    - `omit_blob_tests` for DBMS that don't have a BLOB data type.
    - `current_needs_parens` -- some SQL dialects (e.g., BigQuery) require parentheses for the functions `current_date`, `current_time` and `current_timestamp`.
    - `union`, for specifying a nonstandard way of combining queries. All union queries now name each column in each subquery (required for `bigrquery`).

- New tests
    - `dbGetInfo(Result)` (r-dbi/DBI#55).
    - `dbListFields()` (#26).
    - New "package_name" test in `test_getting_started()`.
- Improved tests
    - Stress test now installs package in temporary library (before loading `DBI`) using `R CMD INSTALL` before loading DBI (r-dbi/RSQLite#128, #48).
    - Row count is now tested for equality but not identity, so that backends can return a numeric value > 2^31 at their discretion.
    - Call `dbRemoveTable()` instead of issuing `DROP` requests, the latter might be unsupported.
    - Use subqueries in queries that use `WHERE`.
    - Test that `dbClearResult()` on a closed result set raises a warning.
    - Expect a warning instead of an error for double disconnect (#50).
    - Move connection test that requires `dbFetch()` to `test_result()`.
    - Split "can_connect_and_disconnect" test.
    - Expect `DBI` to be in `Imports`, not in `Depends`.
- Removed tests
    - Remove test for `dbGetException()` (r-dbi/DBI#51).
- Bug fixes
    - Fix broken tests for quoting.
- Self-testing
    - Test `RPostgres`, `RMySQL`, `RSQLite` and `RKazam` as part of the Travis-CI tests (#52).
    - Travis CI now installs rstats-db/DBI, updated namespace imports (`dbiCheckCompliance()`, `dbListResults()`).

    - Use fork of `testthat`.
- Utilities
    - Return test results as named array of logical. Requires r-lib/testthat#360, gracefully degrades with the CRAN version.
- Internal
    - Refactored the `get_info_()` tests to use a vector of names.
    - Use versioned dependency for DBI
    - Use unqualified calls to `dbBind()` again
- Same as 1.0-8.
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants