Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nanodbc: Fix build / assert warning #519

Merged
merged 1 commit into from
Dec 9, 2022
Merged

nanodbc: Fix build / assert warning #519

merged 1 commit into from
Dec 9, 2022

Conversation

detule
Copy link
Collaborator

@detule detule commented Nov 22, 2022

Fixes #512

@detule detule requested a review from hadley December 9, 2022 02:19
hadley
hadley approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be backported to nanodbc?

@detule
Copy link
Collaborator Author

detule commented Dec 9, 2022

Thanks Hadley:

This ASSERT looks to already be fixed upstream.

@detule detule merged commit ee9629c into r-dbi:main Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadley hadley hadley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package C++ code fails to compile due to invalid static_cast in nanodbc.cpp
2 participants
@detule @hadley