Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment updates #468

Closed
hadley opened this issue Jan 2, 2022 · 6 comments
Closed

Deployment updates #468

hadley opened this issue Jan 2, 2022 · 6 comments

Comments

@hadley
Copy link
Member

hadley commented Jan 2, 2022

  • pkgdown workflows need update to use pkgdown::build_site_github_pages() + GitHub pages deployment
  • blogdown and bookdown text needs to be update to remove mention of netlify
@gaborcsardi
Copy link
Member

blogdown and bookdown text needs to be update to remove mention of netlify

Is this because the examples do not support netlify any more?

@hadley
Copy link
Member Author

hadley commented Jan 5, 2022

Right. For the vast majority of use cases, github pages is the way to do, so thats what we want to steer people towards.

@gaborcsardi
Copy link
Member

The pkgdown example workflow uses pkgdown::deploy_to_branch(), isn't that good? It calls build_site_github_pages() internally, and then github_push().

What do you mean by GitHub Pages deployment? Should we use a GH Pages deployment action instead?

gaborcsardi added a commit that referenced this issue Jan 5, 2022
@hadley
Copy link
Member Author

hadley commented Jan 5, 2022

I think we want to move away from building and deploying the site in one step, because:

  • It's useful to build the site even when it's not deployed (i.e. to reveal problems in external PRs)
  • It's easier to understand if all the examples use the same mechanism of deploying to GitHub pages.

gaborcsardi added a commit that referenced this issue Jan 6, 2022
@gaborcsardi
Copy link
Member

OK, the new workflow is indeed simpler, and it is now included in v2.

@github-actions
Copy link

github-actions bot commented Nov 6, 2022

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this issue

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants