-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using GITHUB_TOKEN for Pandoc nightly download #868
Labels
bug
an unexpected problem or unintended behavior
Comments
🤔 I got this when adding
So possibly |
cderv
added a commit
to rstudio/rmarkdown
that referenced
this issue
Jul 2, 2024
Revert to using own custom action waiting for r-lib/actions#868 to be fixed
cderv
added a commit
to rstudio/bookdown
that referenced
this issue
Jul 2, 2024
as we wait for r-lib/actions#868 to be fixed
yihui
pushed a commit
to rstudio/bookdown
that referenced
this issue
Jul 2, 2024
as we wait for r-lib/actions#868 to be fixed
gaborcsardi
added a commit
that referenced
this issue
Jul 31, 2024
This is now needed, apparently. Closes #868.
This issue has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this issue |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Not sure what changed, but I recently get pandoc nightly download to fail. Here is the debug logging
from https://github.com/rstudio/rmarkdown/actions/runs/9518128513/job/26246875020#step:7:47
I am wondering if the
token
input is correctly passed to the API call 🤔gh
CLI locally it worksgh api /repos/jgm/pandoc/actions/artifacts/1601304781/zip > nightly.zip
I don't know a lot about
@action/core
but I see we do this for nightlyactions/setup-pandoc/src/setup-pandoc.ts
Line 111 in fbafc3b
and so we create octokit without the GITHUB_TOKEN.
There is a function to get Auth Header
actions/setup-pandoc/src/setup-pandoc.ts
Lines 92 to 100 in fbafc3b
but it is not used in the script... So I wonder.
Is
token
input really used ? Or should we authenticate another way ?I have seen in https://github.com/octokit/action.js/ that maybe setting GITHUB_TOKEN env could work so trying that now.
rstudio/rmarkdown#2559
The text was updated successfully, but these errors were encountered: