Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose profile arg from renv::activate() #649

Merged
merged 6 commits into from
Oct 26, 2022
Merged

Expose profile arg from renv::activate() #649

merged 6 commits into from
Oct 26, 2022

Conversation

Bisaloo
Copy link
Contributor

@Bisaloo Bisaloo commented Oct 24, 2022

Tested here.

Fix #648

Copy link
Member

@gaborcsardi gaborcsardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good, added some questions.

setup-renv/README.md Outdated Show resolved Hide resolved
setup-renv/action.yaml Outdated Show resolved Hide resolved
Co-authored-by: Indrajeet Patil <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2022

Codecov Report

Merging #649 (dc86230) into v2-branch (20ffd99) will not change coverage.
The diff coverage is n/a.

❗ Current head dc86230 differs from pull request most recent head 8cdc630. Consider uploading reports for the commit 8cdc630 to get more accurate results

@@             Coverage Diff             @@
##           v2-branch      #649   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
===========================================
  Files              2         2           
  Lines             10        10           
===========================================
  Hits              10        10           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gaborcsardi gaborcsardi merged commit 990b4e1 into r-lib:v2-branch Oct 26, 2022
@gaborcsardi
Copy link
Member

Thank you!

@Bisaloo Bisaloo deleted the renv-profile branch October 26, 2022 09:01
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose profile argument in setup-renv
4 participants