Fixes #1851 Executed styler against package source #1862
Conversation
| #usethis::use_data(..., internal = internal, overwrite = overwrite, | ||
| #compress = compress) | ||
| #} | ||
| # function(..., pkg = ".", internal = FALSE, overwrite = FALSE, |
There was a problem hiding this comment.
styler removed all function indentation as extra whitespaces, so I added it back. It will get removed each time styler is run against this file, though.
R/install.r
Outdated
| if (is_loaded(pkg)) { | ||
| eapply(pkgload::ns_env(pkg$package), force, all.names = TRUE) | ||
| } | ||
| args = getOption("devtools.install.args"), quiet = FALSE, |
There was a problem hiding this comment.
This whole file is not noticeably changed much by styler. The side-by-side compare is mixed-up for reasons I can't discern.
|
I ran devtools::document() to generate a new check.Rd for the latest change to that file, as it was the only error in TravisCI. Doing so only revealed other errors in the build. Should I remove the check.Rd change and/or wait to address this PR once the test failures are resolved? |
|
Looks good to me, thanks! Could you add a note to NEWS.md documenting the change and mentioning the issue # and your GitHub name. Don't worry about the travis errors, I will fix them after merging. |
|
Also if you want GitHub to map your commits to your GitHub user you will need to add the email you used in the commits to https://github.com/settings/emails |
AmundsenJunior
force-pushed
the
styler
branch
2 times, most recently
from
4eb653b to
b2fdabb
Compare
|
@jimhester Updated NEWS.md and the email address. Thanks. |
AmundsenJunior
force-pushed
the
styler
branch
from
b2fdabb to
04f5bbe
Compare
DESCRIPTION
Outdated
| @@ -57,6 +57,7 @@ Suggests: | |||
| rversions, | |||
| sessioninfo, | |||
| spelling (>= 1.1), | |||
| styler, | |||
There was a problem hiding this comment.
I think we should probably leave styler out of Suggests. While it is nice to have it as a hint for contributors it has a non-trivial number of dependencies which would need to be installed on the CI systems for each build. So if we aren't actually going to use it there I think it would be better to omit it.
There was a problem hiding this comment.
Will do. Done.
AmundsenJunior
force-pushed
the
styler
branch
2 times, most recently
from
bfd42e1 to
d3420b7
Compare
Fixes r-lib#1851 Updated documentation for check.R change Updated NEWS.md with styler change
|
Thanks again! |
Fixes #1851
Added 'styler' to package 'Suggests'Might be a good note to package contributors to also run
stylerin the future, but not sure where (README, or elsewhere) to put this information: