Add an exception for box::use()
to infix spaces linter
#1105
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1087, this is a draft to extend the
infix_spaces_linter
with an exception forlhs/rhs
expressions inside abox::use()
call, which represent import declarations that should resemble file paths, and thus don’t call for spaces around/
.My XPath-fu is fairly rusty so I’d appreciate a review of the implementation. I’ve opted not to modify the rule’s current XPath, instead filtering the resulting lint list by excluding all occurrences of
/
insidebox::use()
. The XML structure of the parsed expressions makes this somewhat awkward, because rather than being nested (as I naïvely expected), the surroundingbox::use()
call expression is adjacent to the parent node of the/
expression.I’m not 100% sure whether my way of testing for a
box::use()
call is maximally specific or whether it could lead to false positives … however, I can’t see how this would happen.