Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add examples to documentation: Part-7 (q-s) #1674
Add examples to documentation: Part-7 (q-s) #1674
Changes from all commits
beee9d9
0ec9f9e
7c01a83
1183f6d
49d1772
15ac9c1
73e8aa0
8639ddd
8de9afb
253026e
33469f4
e72971d
2dcc709
454959c
ac869a9
f259842
a044e55
213bf3b
ef84b97
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in an earlier linter (function_left_parentheses_linter? is that the name?) we showed if/function signature examples, should we do the reverse here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what you mean by "reverse" here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Complementary examples to these:
lintr/R/function_left_parentheses_linter.R
Lines 21 to 40 in 615f72a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So including the okay examples but with a space to show that this doesn't lint with spaces_left linter?
Created on 2022-10-11 with reprex v2.0.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, now I'm doubting everything :)
I definitely don't think examples like
mean (x)
are helpful... but maybe the better thing to do is just remove theif()
example fromfunction_left_parentheses_linter()
? Sinceif()
is irrelevant to that linter, and is covered here instead.And then add cross-links between these two linters' help pages since they're so closely related.
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM. I have made the necessary changes. See if this is better.