Make helpers default depend on export_all (#259)

Closes #244
r-lib · Sep 21, 2023 · 8aebdb5 · 8aebdb5
1 parent e828276
commit 8aebdb5
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -4,6 +4,10 @@
 
 * Fix handling of active bindings inside a package during unloading (#255, @klmr).
 
+* The `helpers` argument of `load_all` now defaults to the value
+  provided for the `export_all` arguments. This makes the behaviour
+  safer by default (#244).
+
 
 # pkgload 1.3.3
 

diff --git a/R/load.R b/R/load.R
@@ -118,7 +118,7 @@ load_all <- function(path = ".",
                      attach = TRUE,
                      export_all = TRUE,
                      export_imports = export_all,
-                     helpers = TRUE,
+                     helpers = export_all,
                      attach_testthat = uses_testthat(path),
                      quiet = NULL,
                      recompile = FALSE,

diff --git a/man/load_all.Rd b/man/load_all.Rd