Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if biocViews is empty #25

Merged
merged 6 commits into from
Oct 8, 2018
Merged

Check if biocViews is empty #25

merged 6 commits into from
Oct 8, 2018

Conversation

llrs
Copy link
Contributor

@llrs llrs commented Oct 8, 2018

As discussed in #24 I implemented the change.

I added a bullet in the NEWS trying to keep the format and bumped the version using usethis::use_version.

Copy link
Member

@gaborcsardi gaborcsardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good, requested some small changes.

@codecov-io
Copy link

codecov-io commented Oct 8, 2018

Codecov Report

Merging #25 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #25   +/-   ##
=======================================
  Coverage   92.73%   92.73%           
=======================================
  Files           8        8           
  Lines         234      234           
=======================================
  Hits          217      217           
  Misses         17       17
Impacted Files Coverage Δ
R/package-info.R 92.92% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f91fad...b65a468. Read the comment docs.

@gaborcsardi
Copy link
Member

Thanks! Just one more tiny formatting request above.

@gaborcsardi
Copy link
Member

Thanks much!

@gaborcsardi gaborcsardi merged commit 9645364 into r-lib:master Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants