Add a names<- method for vctrs_rcrd
#1422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionel-
approved these changes
Aug 16, 2021
DavisVaughan
force-pushed
the
fix/rcrd-set-names
branch
from
41e68fb to
43db268
Compare
This is a no-op for `NULL` names, but otherwise errors. We should reconsider this in the future once we are ready to try and support names on rcrds, but for now this prevents `vec_set_names()` from corrupting rcrd types.
DavisVaughan
force-pushed
the
fix/rcrd-set-names
branch
from
43db268 to
4646cbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1419
This is a no-op for
NULLnames, but otherwise errors. We should reconsider this in the future once we are ready to try and support names on rcrds, but for now this preventsvec_set_names()from corrupting rcrd types.