Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add importFrom grDevices cm #2276

Merged
merged 1 commit into from
Nov 29, 2023
Merged

add importFrom grDevices cm #2276

merged 1 commit into from
Nov 29, 2023

Conversation

rsbivand
Copy link
Member

I see that work on the plot key.width issue is ongoing. In looking at GDAL 3.8.1RC3 (from last night), I noticed:

* checking R code for possible problems ... NOTE
.image_scale_factor : <anonymous>: no visible global function
  definition for ‘cm’
kw_dflt: no visible global function definition for ‘cm’
Undefined global functions or variables:
  cm
Consider adding
  importFrom("grDevices", "cm")
to your NAMESPACE file.

so added to R/init.R and ran devtools::document, hence this PR.

@edzer edzer merged commit 9d2a86e into r-spatial:main Nov 29, 2023
1 of 7 checks passed
@edzer
Copy link
Member

edzer commented Nov 29, 2023

Ongoing indeed, hope to continue / finish Thu later & Friday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants