Fix Ctrl-Command-Power reboot key combo #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the reboot key combo is held down the Mac OS does a talk reg 2 continuously until the modifier keys are lifted. The talk reg 2 wasn't being updated during that loop so system would start. Now reg 2 is checked right before it is sent over the ADB bus so the modifier keys are always current. Another fix was done with the power button. The power key up state was malformed so the power button was stuck down after pressing it. This has been fixed. Removed code related to double queuing the power button on the USB side. The double queuing is done now on the ADB side. The power button takes up both key press packets so it need to be queued twice and sent on the same talk register 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the reboot key combo is held down the Mac OS does a talk reg 2 continuously until the modifier keys are lifted. The talk reg 2 wasn't being updated during that loop so system would start.
Now reg 2 is checked right before it is sent over the ADB bus so the modifier keys are always current.
Another fix was done with the power button. The power key up state was malformed so the power button was stuck down after pressing it. This has been fixed.
Removed code related to double queuing the power button on the USB side. The double queuing is done now on the ADB side. The power button takes up both key press packets so it need to be queued twice and sent on the same talk register 0.