feat: add $nth operator to questDk #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 063813c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Forgot to add type here Line 3 in 8b36b8a Will add this asap |
mmackz
commented
Jan 26, 2024
| @@ -10,6 +10,12 @@ export type ArrayOperator = | |||
| | { | |||
| $last?: FilterOperator | |||
| } | |||
| | { | |||
There was a problem hiding this comment.
Looks right I just cleaned it up into it's own type
It's set manually for each build command we don't need a default value
|
Size Change: +198 B (+1%) Total Size: 23.5 kB
ℹ️ View Unchanged
|
Quazia
previously approved these changes
Feb 6, 2024
| @@ -10,6 +10,12 @@ export type ArrayOperator = | |||
| | { | |||
| $last?: FilterOperator | |||
| } | |||
| | { | |||
There was a problem hiding this comment.
Looks right I just cleaned it up into it's own type
Quazia
approved these changes
Feb 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a $nth array operator which can be used to target specific items inside an array of parameters. It complements the $first, $last, and $some operators.
Tests were added to ensure the correct functionality of the $nth operator under various scenarios. These include validating that the operator correctly identifies the nth item in an array and that it will correctly handle when n exceeds the array length.