tests: add testcase to ensure reader routine terminates #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a testcase for the bug that the reader go-routine tries to send a message to the buffered rpc channel but call() terminated because it read an error from the errors chan or the errors chan was closed. It cause that reader routine gets stuck forever and does not terminate when the connection is closed. More information: rabbitmq#69. This testcase does not reproduce the issue reliably, but it is triggered in ~80% of executions.
|
Thanks, I've merged this into #70 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a testcase for the bug that the reader go-routine tries to send a
message to the buffered rpc channel but call() terminated because it
read an error from the errors chan or the errors chan was closed.
It cause that reader routine gets stuck forever and does not terminate
when the connection is closed.
More information: #69.
This testcase does not reproduce the issue reliably, but it is triggered
in ~80% of executions.
This PR adds a testcase for the issue #69 and the fix #70.
If you have an idea how to trigger the bug reliably in a testcase, please let me know.