Support additional env args #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If attribute node['node']['additional_env_settings'] exists, it is expected to be an array of strings, which will then be appended to rabbit-env.conf. This allows users the flexibility to specify ENV settings that don't have explicit attributes. (E.g. Some settings may be new to rabbitmq but won't require a recipe update before people can take advantage of them.) I also cleaned up a couple of rubocop issues in default_spec.rb
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If attribute node['node']['additional_env_settings'] exists, it is
expected to be an array of strings, which will then be appended
to rabbit-env.conf. This allows users the flexibility to specify
ENV settings that don't have explicit attributes. (E.g. Some
settings may be new to rabbitmq but won't require a recipe update
before people can take advantage of them.)
I also cleaned up a couple of rubocop issues in default_spec.rb