fix idempotency #555
Merged
fix idempotency #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wing924 <[email protected]>
|
Thank you, I will test this later today. |
|
Thank you! |
11 tasks
|
Unfortunately, this makes |
|
I have kept multiple runs to weed out the most problematic idempotency issues but disabled idempotency enforcement by the Chef client resource state tracker. We would definitely consider more PRs that improve idempotency of providers and recipes in this cookbook 💚 |
michaelklishin
added a commit
that referenced
this pull request
Jul 27, 2020
This is a nice idea in theory and a truly terrible one to my productivity in practice: it makes 'kitchen converge' fail with hard to reason about "resource changed" errors that involve resources such as 'directory[/etc/rabbitmq]'. Unless practically relevant issues with recipe idempotency are found, I'd take a productive development flow over hours spend troubleshooting 'kitchen converge' runs that are non-idempotent according to the Chef resource change tracker. Note that we do preserve multiple runs per convergence, which should weed out obvious practical issues with non-idempotency of our recipes. References #555.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR is to keep idempotency of this cookbook.
The ohai 'reload_packages' do nothing when no package is installed but still report that some resources are changed.