feat(ipv6): add support for IPv6 env #1455
Conversation
|
Any update on this PR review? |
There was a problem hiding this comment.
Thank you for your contributions. I agree the Operator can ease the configuration of IPv6 only environments, however, I don't agree with the approach of this PR. One key point is that this PR comes with 0 new tests and no explanation of why tests were not included.
Our philosophy regarding adding fields to the custom resource is to make commonly used features easy to configure. I don't think IPv6-only configuration is common.
This particular implementation is quite britle, because it does hard equal validation between two strings. In other words, the feature only activates if IPFamily is exactly IPv6, and it doesn't activate if IPFamily is ipv6. There's no validation of the input string, I could insert "abcd" string and the Operator will silently ignore it and succeed the reconcile. That's not good, because there's no feedback to the user that they made a mistake.
The approach I would/will take to ease the configurability of IPv6 only environments would/will be:
- Provide an input to configure
erl_inetrcfile, and mount/inject that file into the container - Append the necessary configuration to make rabbit use the relevant env variables (instead of hard setting)
- Write an example to document how to set IPv6-only
You've done a lot by reporting the issue and suggesting a solution, therefore I won't ask you to take on this suggestion, and understand if you simply close this PR.
|
Solid comment. Yeah, I agree a more general way will be better. Thanks for taking care of the review. |
Test with kind-ipv6 cluster. Ref: https://kind.sigs.k8s.io/docs/user/configuration/
The solution is also tested in AWS EKS. The solution follows discussion in rabbitmq/rabbitmq-server#6820 (comment)