Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore mirroring related shutdown errors #1740

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

mkuratczyk
Copy link
Collaborator

RabbitMQ 4.0 doesn't include the mirroring-specific command rabbitmq-upgrade await_online_synchronized_mirror. Therefore, the preStop hook would fail on 4.0, leading to the maintenance mode not getting enabled at all (the moment a command fails in preStop, the shutdown process continues as if preStop completed).

This approach should make the Operator compatible with 3.x and 4.x.

This closes #1734

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
RabbitMQ 4.0 doesn't include the mirroring-specific command `rabbitmq-upgrade await_online_synchronized_mirror`.
Therefore, the preStop hook would fail on 4.0, leading to the
maintenance mode not getting enabled at all (the moment a command fails
in preStop, the shutdown process continues as if preStop completed).

This approach should make the Operator compatible with 3.x and 4.x.
@mkuratczyk mkuratczyk merged commit aa72d5d into main Oct 8, 2024
15 checks passed
@mkuratczyk mkuratczyk deleted the 4.0-compatibility branch October 8, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated mirrored queue majority check
3 participants