Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stale consistent read result after server restart #342

Merged
merged 1 commit into from
Dec 21, 2022

Conversation

kjnilsson
Copy link
Contributor

@kjnilsson kjnilsson commented Dec 16, 2022

Reset cluster_change_permitted when becoming leader

As if there had been a leader change before this could reset to true
even before the leader has fully applied it's noop command for the new
term. This could result in occasional stale consistent read results.

@kjnilsson kjnilsson changed the title Add occasionally failing test Fix stale consistent read result Dec 21, 2022
@kjnilsson kjnilsson marked this pull request as ready for review December 21, 2022 11:25
As if there had been a leader change before this could reset to true
even before the leader has fully applied it's noop command for the new
term. This could result in occasional stale consistent read results.
@kjnilsson kjnilsson changed the title Fix stale consistent read result Fix stale consistent read result after server restart Dec 21, 2022
@kjnilsson
Copy link
Contributor Author

I ran the consistent_query_after_restart test in a loop for 20 minutes without failures. Before the fix I could get it to fail every 5 runs or so.

@michaelklishin michaelklishin added this to the 2.4.6 milestone Dec 21, 2022
@michaelklishin michaelklishin merged commit e99ec0b into main Dec 21, 2022
@michaelklishin michaelklishin deleted the stale-read-redux branch December 21, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants