ra_aux: Expose effective machine version, current term #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A machine might want this information to determine if it should emit
an effect like `{append, NewCmd}` that can only be handled once a
cluster reaches an effective machine version.
With `current_term/1` (this change), `last_applied/1` and `effective_machine_version/1` from the parent commit, the aux API reflects essentially the same information as is passed as metadata to the `RaMachine:apply/3` callback (`ra_machine:command_meta_data()`).
the-mikedavis
changed the title
kjnilsson
approved these changes
Oct 16, 2024
dumbbell
added a commit
to rabbitmq/khepri
that referenced
this pull request
Oct 28, 2024
Release notes: https://github.com/rabbitmq/ra/releases/tag/v2.15.0 In particular, we need rabbitmq/ra#474 for a future change in Khepri.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A machine might want to know the effective machine version to determine if it should emit an effect like
{append, NewCmd}that can only be handled once a cluster reaches an effective machine version.This change also exposes the
current_termso that the callers of the ra_aux API have essentially the same metadata as is passed to theRaMachine:apply/3callback.