Force pipelined rpcs for noop command. #506
Merged
+42
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjnilsson
force-pushed
the
candidate-rpc-fix
branch
3 times, most recently
from
d671a73 to
979dbe4
Compare
mkuratczyk
approved these changes
Feb 3, 2025
Instead of the candidate sending a set of empty rpcs before entering leader state, ensure rpcs are sent for all followers by forcing pipelined rpcs to be generated when the command is a noop command. This fixes potential issues with leader election timeliness. Some formatting fixes.
kjnilsson
force-pushed
the
candidate-rpc-fix
branch
from
979dbe4 to
143414b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of the candidate sending a set of empty rpcs before entering leader state, ensure rpcs are sent for all followers by forcing pipelined rpcs to be generated when the command is a noop command.
This fixes potential issues with leader election timeliness.