Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make per-consumer delivery acknowledgement timeout configurable per-queue (via a policy) and per-consumer (via consumer args) #5437

Closed
michaelklishin opened this issue Aug 4, 2022 · 3 comments · Fixed by #7981
Closed

Make per-consumer delivery acknowledgement timeout configurable per-queue (via a policy) and per-consumer (via consumer args) #5437

michaelklishin opened this issue Aug 4, 2022 · 3 comments · Fixed by #7981
Assignees
@michaelklishin @ikavgo
Milestone
3.12.0

Comments

@michaelklishin
Copy link
Member

michaelklishin commented Aug 4, 2022 •
edited
Loading

I won't recite the discussion in #4099 but there's some interest on our team in making consumer delivery acknowledgement timeout configurable per virtual host, queue or consumer, and not just globally.

Starting with 3.11, virtual host metadata is a pre-enabled feature flag, so there is interest in using it more.

This may bring us closer to taking the setting from the optional queue arguments, if any, but this is not in scope for the spike.

Suggested duration: no more than two full days.
@michaelklishin michaelklishin self-assigned this Aug 4, 2022
@rabbitmq rabbitmq locked and limited conversation to collaborators Aug 4, 2022
@ikavgo
Copy link
Contributor

ikavgo commented Jan 31, 2023

@michaelklishin are you on it? I'm happy to take care of this

@ikavgo ikavgo self-assigned this Jan 31, 2023
@michaelklishin
Copy link
Member Author

@ikvmw go ahead.

@ikavgo
Copy link
Contributor

ikavgo commented Feb 7, 2023

As per slack discussion:

  • won't do per-vhost;
  • will do per queue (like with dead lettering x- and policy)
  • will do per consumer.

Precedence Per consumer, per queue, global.

@michaelklishin michaelklishin changed the title Spike: per-vhost delivery acknowledgement timeout Spike: per-queue and per-consumer delivery acknowledgement timeout Feb 7, 2023
ikavgo pushed a commit that referenced this issue Apr 9, 2023
@deadtrickster
Allow setting consumer timeout via queue policy/arg and as consumer a…
ab251b5 
…rg. Close #5437
ikavgo pushed a commit that referenced this issue Apr 25, 2023
@deadtrickster
Allow setting consumer timeout via queue policy/arg and as consumer a…
1f8f868 
…rg. Close #5437
ikavgo pushed a commit that referenced this issue Apr 25, 2023
@deadtrickster
Allow setting consumer timeout via queue policy/arg and as consumer a…
ba5426e 
…rg. Close #5437
ikavgo pushed a commit that referenced this issue Apr 25, 2023
@deadtrickster
Allow setting consumer timeout via queue policy/arg and as consumer a…
4e8f05e 
…rg. Close #5437
mergify bot pushed a commit that referenced this issue Apr 26, 2023
@deadtrickster @mergify
Allow setting consumer timeout via queue policy/arg and as consumer a…
5dd8848 
…rg. Close #5437

(cherry picked from commit 4e8f05e)
mergify bot pushed a commit that referenced this issue Apr 26, 2023
@deadtrickster @mergify
Allow setting consumer timeout via queue policy/arg and as consumer a…
9d62679 
…rg. Close #5437

(cherry picked from commit 4e8f05e)
(cherry picked from commit 5dd8848)

# Conflicts:
#	deps/rabbit/src/rabbit_channel.erl
@michaelklishin michaelklishin added this to the 3.12.0 milestone Apr 26, 2023
@michaelklishin michaelklishin changed the title Spike: per-queue and per-consumer delivery acknowledgement timeout Make per-consumer delivery acknowledgement timeout configurable per-queue (via a policy) and per-consumer (via consumer args) Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@michaelklishin michaelklishin

@ikavgo ikavgo

Labels
None yet
Projects
None yet
Milestone
3.12.0
2 participants
@michaelklishin @ikavgo