Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP API: GET /api/nodes/{node} should return important information when stats are disabled #8556

Open
lukebakken opened this issue Jun 13, 2023 · 1 comment
Assignees

Comments

@lukebakken
Copy link
Collaborator

lukebakken commented Jun 13, 2023

Is your feature request related to a problem? Please describe.

To get information about partitions, you must have management statistics enabled. Ideally, it would be great to still get that information, and other critical info, when management stats are disabled.

Here is a script I made to make several HTTP API requests and write their results to a file:

https://github.com/lukebakken/vesc-1073/blob/main/http-api-requests.ps1

This is what is returned when stats are disabled:
no-stats-output.txt

This is what is returned when stats are enabled. Note that partitions, mem_alarm and disk_free_alarm are returned. I would consider those to be important:
with-stats-output.txt

Describe the solution you'd like

The HTTP API request should return information about partitions and alarms.

Describe alternatives you've considered

N/A

Additional context

Related to:

@lukebakken lukebakken self-assigned this Jun 13, 2023
@michaelklishin michaelklishin changed the title HTTP API request to /api/nodes/NAME should return important information when stats are disabled HTTP API: GET /api/nodes/{node} should return important information when stats are disabled Jun 13, 2023
@lukebakken
Copy link
Collaborator Author

#9465 implements the equivalent of partitions for the Prometheus endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant