Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose number of unreachable cluster peers via Prometheus #9465

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

gomoripeti
Copy link
Contributor

@gomoripeti gomoripeti commented Sep 19, 2023

Proposed Changes

Unreachable peers is a subset of DB cluster nodes that are not connected to the current node via Erlang distribution for any reason.

As discussed in #9376
Closes #2508 (to the extent agreed to in #9376)

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

Unreachable peers is a subset of DB cluster nodes that are not connected
to the current node via Erlang distribution for any reason.
@mergify mergify bot added the bazel label Sep 19, 2023
Copy link
Member

@michaelklishin michaelklishin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Start a three node cluster with bazel run start-cluster, shut down two nodes out of three, observe

# TYPE rabbitmq_unreachable_cluster_peers_count gauge
# HELP rabbitmq_unreachable_cluster_peers_count Number of peers in the cluster the current node cannot reach.
rabbitmq_unreachable_cluster_peers_count 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prometheus: expose a metric for network partition observed on the node
2 participants