Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Management UI: arranged and reorganized vertical bars in management console when declaring queues #12658

Closed
wants to merge 1 commit into from

Conversation

markus812498
Copy link
Contributor

Proposed Changes

Formatting and organising the vertical bars and list of parameters for queues in the management console to make it look nicer and more structured.

Types of Changes

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

@markus812498 markus812498 marked this pull request as ready for review November 4, 2024 22:01
@michaelklishin michaelklishin changed the title Arranged and reorganized vertical bars in management console when declaring queues Management UI: arranged and reorganized vertical bars in management console when declaring queues Nov 4, 2024
@michaelklishin
Copy link
Member

michaelklishin commented Nov 6, 2024

@markus812498 @LoisSotoLopez @gomoripeti I would really appreciate if before submitting a PR, any PR, for any branch, CloudAMQP engineers would update the base branch to the latest.

This branch is 148 commits behind. The core team routinely has to rebase dozens of not several hundreds of commits for PRs originating from your GitHub fork.

For example, right now I cannot even take a look at the change because there are no "before/after" screenshots and rebasing fails with a conflict.

I have resolved the conflict, and there was another one. And another one. And another one. I have given up on conflict number 6.

Why some of the unrelated changes conflict with forks weeks behind, I don't know. But I do know that PRs from other contributors virtually never have this problem.

@michaelklishin
Copy link
Member

And yes, I can create a new local branch and cherry-pick 98c2363 there.

Not every PR has just one commit, and I am not going to squash them to then create a branch to then cherry pick the squashed commit.

@michaelklishin
Copy link
Member

Before (4.0.3)

Before rabbitmq-server#12658

After

After rabbitmq-server#12658

@markus812498
Copy link
Contributor Author

@markus812498 @LoisSotoLopez @gomoripeti I would really appreciate if before submitting a PR, any PR, for any branch, CloudAMQP engineers would update the base branch to the latest.

This branch is 148 commits behind. The core team routinely has to rebase dozens of not several hundreds of commits for PRs originating from your GitHub fork.

For example, right now I cannot even take a look at the change because there are no "before/after" screenshots and rebasing fails with a conflict.

I have resolved the conflict, and there was another one. And another one. And another one. I have given up on conflict number 6.

Why some of the unrelated changes conflict with forks weeks behind, I don't know. But I do know that PRs from other contributors virtually never have this problem.

You're right, I must've forgot to pull down the latest changes from upstream. I'll make sure to do that going forward, sorry for the hassle.

@michaelklishin
Copy link
Member

michaelklishin commented Nov 6, 2024

Moved to #12677.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants