-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Definition export: inject default queue type into virtual host metadata #12821
Conversation
All the parts you've worked on so far work well for me. There's one more endpoint which I think should Additionally, |
@mkuratczyk ready for another round. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great, thanks. The only thing that I wasn't 100% sure about is that
if you export definitions with a DQT set and import them to a fresh node (that just defaults to classic
), the DQT doesn't get set to the value from the definitions JSON.
But given that imports are additive, I think that's ok - we are not overriding an existing value.
Definition export: inject default queue type into virtual host metadata (backport #12821)
With this change,
GET /api/definitions
andGET /api/vhosts
will inject a default queue type (DQT) into virtual host metadata whendefault_queue_type
is set inrabbitmq.conf
(v4.0.x
-only) and the virtual host in question does not have DQT defined for it:default_queue_type = quorum
Closes #12776.
Closes #12835.