Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Definition export: inject default queue type into virtual host metadata #12821

Merged
merged 8 commits into from
Nov 27, 2024

Conversation

michaelklishin
Copy link
Member

@michaelklishin michaelklishin commented Nov 26, 2024

With this change, GET /api/definitions and GET /api/vhosts will inject a default queue type (DQT) into virtual host metadata when default_queue_type is set in rabbitmq.conf (v4.0.x-only) and the virtual host in question does not have DQT defined for it:

default_queue_type = quorum

Closes #12776.
Closes #12835.

@mkuratczyk
Copy link
Contributor

All the parts you've worked on so far work well for me. There's one more endpoint which I think should
have the DQT: /api/definitions/vhost (eg /api/definitions/%2F). Right now it contains no metadata whatsoever right now and therefore no DQT.

Additionally, rabbitmqctl export_definitions (completely different code path unfortunately).

@michaelklishin michaelklishin marked this pull request as ready for review November 27, 2024 17:49
@michaelklishin
Copy link
Member Author

@mkuratczyk ready for another round.

@michaelklishin michaelklishin changed the title Inject default queue type into virtual host metadata Definition export: inject default queue type into virtual host metadata Nov 27, 2024
Copy link
Contributor

@mkuratczyk mkuratczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks. The only thing that I wasn't 100% sure about is that
if you export definitions with a DQT set and import them to a fresh node (that just defaults to classic), the DQT doesn't get set to the value from the definitions JSON.
But given that imports are additive, I think that's ok - we are not overriding an existing value.

@michaelklishin michaelklishin merged commit 1cae417 into main Nov 27, 2024
271 of 272 checks passed
@michaelklishin michaelklishin deleted the rabbitmq-server-12776 branch November 27, 2024 19:53
michaelklishin added a commit that referenced this pull request Nov 27, 2024
Definition export: inject default queue type into virtual host metadata (backport #12821)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants