Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent node monitor crashing from doing multiple node disconnects in unstable networks (backport #9663) #9667

Merged
merged 3 commits into from
Oct 9, 2023
Merged

Prevent node monitor crashing from doing multiple node disconnects in unstable networks (backport #9663) #9667

merged 3 commits into from
Oct 9, 2023

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Oct 9, 2023

This is an automatic backport of pull request #9663 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@Ayanda-D @mergify
prevent multiple node disconnects in unstable networks
0e57d92 
when nodes are already disconnected, thus preventing
application controller timeouts and node monitor terminations,
which in some cases fails to receover completely.

(cherry picked from commit 7ce9d86)
@Ayanda-D @mergify
announce partition handling mechanism in node monitor start-up log
864ec12 
(cherry picked from commit bc1af7c)
@Ayanda-D @mergify
oops, fix parameter ordering
c55b431 
(cherry picked from commit 6e5ad7d)
@michaelklishin michaelklishin added this to the 3.12.7 milestone Oct 9, 2023
@michaelklishin michaelklishin merged commit affa8c3 into v3.12.x Oct 9, 2023
@michaelklishin michaelklishin deleted the mergify/bp/v3.12.x/pr-9663 branch October 9, 2023 22:27
@mergify mergify bot mentioned this pull request Oct 9, 2023
Merged
michaelklishin added a commit that referenced this pull request Oct 9, 2023
@michaelklishin
Merge pull request #9668 from rabbitmq/mergify/bp/v3.11.x/pr-9667
2c100b7 
Prevent node monitor crashing from doing multiple node disconnects in unstable networks (backport #9663) (backport #9667)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-v3.11.x
Projects
None yet
Milestone
3.12.7
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelklishin @Ayanda-D