Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPORTANT] Dear folks who sent pull-request, and are disappointed for the commit that was merged as different name #163

Closed
junaruga opened this issue Apr 26, 2017 · 3 comments

Comments

@junaruga
Copy link
Contributor

junaruga commented Apr 26, 2017

Dear folks.

@Mandaryn #115
@anatol #89
@anatol #90
@benders #127
@bestie #133
@croeck and @Timsly #125
@d-unseductable #112
@davidcelis #132
@iGEL #108
@jdrago999 #124
@jordimassaguerpla #72
@mperham #154
@olivierlacan #146
@reiz #126
@sanemat #70
@scepticulous #141
@tenderlove #131
@terceiro #134
@tgxworld #116
@trevor #81
@codegoalie #120

Dear folks to send pull-request but are disappointed that the PR was not merged directly, but merged to master branch as other people's name.

Maybe I listed up all the target people. But if I missed, let me know.

I am Jun Aruga.
I am working as a maintainer from this month.
First of all, I will apologize that we disappointed you.

We have to admit that we made a mistake for the way to merge. It was not a best way.
Let me tell you why this was happened.

The rack-test project had not worked more than 2 years, as my recognition.
People like you, sent PR or tried to contact to original author.
Though he maintained by alone, he was busy.

However recently this month the situation was changed. You can see a thread [1] for detail.

2 leaders did stand to tackle for the situation.
1st leader had kept own fork merging many PRs to expand rack-test's life time.
2nd leader was able to contact original author, and he was success to move original repository to rack-test/rack-test. You can see this repo's URL is changed to rack-test/rack-test.

They were the light of this project. They recovered this dead project.
They are working for this project as maintainer.
I also joined from this month as maintainer.

Last time only 1 maintainer for rack-test.
But now we have at least 3 maintainers for rack-test. rack-test is enhanced

There are around 10 or 20 people like you, who are disappointed for that.

I will definitely write every people's name like you to History.txt file, though this is not best way.
https://github.com/rack-test/rack-test/blob/master/History.txt

I am happy for you to understand that every people tried to recover rack-test, and spent a time for that. And we made mistake. But now mostly this repository is starting to recover.

I really thank you all very much.

[1] #135

@junaruga junaruga changed the title [IMPORTANT] Dear folks who sent pull-request, and disappointed for the commit was merged as different name [IMPORTANT] Dear folks who sent pull-request, and are disappointed for the commit was merged as different name Apr 26, 2017
@junaruga junaruga changed the title [IMPORTANT] Dear folks who sent pull-request, and are disappointed for the commit was merged as different name [IMPORTANT] Dear folks who sent pull-request, and are disappointed for the commit that was merged as different name Apr 26, 2017
@perlun
Copy link
Contributor

perlun commented Apr 28, 2017

@junaruga really appreciate you taking the time and spending the effort on documenting why this happened. It was an "easy way" for me to try and recover from the lack of maintenance the last years; taking @scepticulous fork was the easiest way to get some of the recent work incorporated.

Sorry for the confusion this caused to you, my apologies. We truly appreciate ALL the contributions from all of you. Let's work really hard to "make rack-test great again"! 😉

@junaruga
Copy link
Contributor Author

@perlun Yes, I can understand you. It was easy way. And we had to do it at that time to recover this repository as faster.

@junaruga junaruga mentioned this issue May 8, 2017
@junaruga
Copy link
Contributor Author

junaruga commented May 8, 2017

I will definitely write every people's name like you to History.txt file, though this is not best way.

History.txt was updated by PR #165

@junaruga junaruga closed this as completed May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants