Allow better testing of cookies #133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It inconvenient to test cookies settings in depth because the current behavior when retrieving a cookie is to return just the value. This can be insufficient when you want to ensure that a cookie is HTTP only or has a particular expiry time. * Add CookieJar#get_cookie to return full cookie object * Add Cookie#http_only? this value was previous somewhat hidden * Add Cookie#to_h which returns all options and values in a Hash
bestie
force-pushed
the
allow-access-to-all-cookie-settings
branch
from
5779172 to
0a9a557
Compare
|
OMG 👍 |
|
+1 for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It inconvenient to test cookies settings in depth because the current
behavior when retrieving a cookie is to return just the value. This can
be insufficient when you want to ensure that a cookie is HTTP only or
has a particular expiry time.